Sign upLogin

theforeman/foreman

View on GitHub
Star
lib/foreman/logging.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method build_layout has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def build_layout(enable_colors = true)
      pattern, colorize = @config[:pattern], @config[:colorize]
      pattern = @config[:sys_pattern] if @config[:type] =~ /^(journald?|syslog)$/i
      colorize = nil unless enable_colors
      case @config[:layout]
Severity: Minor
Found in lib/foreman/logging.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class LoggingImpl has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class LoggingImpl
    private_class_method :new

    attr_reader :config, :log_directory
Severity: Minor
Found in lib/foreman/logging.rb - About 2 hrs to fix

    Method add_logger has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def add_logger(logger_name, logger_config)
      logger = ::Logging.logger[logger_name]
      if logger_config.key?(:enabled)
        if logger_config[:enabled]
          logger.additive = true
    Severity: Minor
    Found in lib/foreman/logging.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status