Sign upLogin

themichaelhall/datatypes

View on GitHub
Star

Showing 40 of 40 total issues

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private function __construct(SchemeInterface $scheme, HostInterface $host, int $port, UrlPathInterface $path, ?string $queryString, ?string $fragment)
Severity: Minor
Found in src/Net/Url.php - About 45 mins to fix

    Method parseParts has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private static function parseParts(array $parts, bool $parseAsDirectory, bool &$isAbsolute, array &$directoryParts, ?string &$filename, ?string &$error): bool
    Severity: Minor
    Found in src/Net/UrlPath.php - About 45 mins to fix

      Method parseParts has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private static function parseParts(array $parts, bool $parseAsDirectory, bool &$isAbsolute, array &$directoryParts, ?string &$filename, ?string &$error): bool
      Severity: Minor
      Found in src/System/FilePath.php - About 45 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function __construct(bool $isAbsolute, int $aboveBaseLevel, ?string $drive, array $directoryParts, ?string $filename)
        Severity: Minor
        Found in src/System/FilePath.php - About 35 mins to fix

          Method validateParts has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private static function validateParts(int $port, UrlPathInterface $path, ?string $queryString, ?string $fragment, ?string &$error): bool
          Severity: Minor
          Found in src/Net/Url.php - About 35 mins to fix

            Method parsePath has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private static function parsePath(string $pathString, ?UrlPathInterface &$path, ?string &$queryString, ?string &$fragment, ?string &$error = null): bool
            Severity: Minor
            Found in src/Net/Url.php - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private static function validateQueryString(?string $queryString, ?string &$error): bool
    {
        if ($queryString === null) {
            return true;
        }
              Severity: Minor
              Found in src/Net/Url.php and 1 other location - About 30 mins to fix
              src/Net/Url.php on lines 767..780

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 91.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private static function validateFragment(?string $fragment, ?string &$error): bool
    {
        if ($fragment === null) {
            return true;
        }
              Severity: Minor
              Found in src/Net/Url.php and 1 other location - About 30 mins to fix
              src/Net/Url.php on lines 744..757

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 91.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this method.
              Open

                      return true;
              Severity: Major
              Found in src/Net/Hostname.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return true;
                Severity: Major
                Found in src/Net/Url.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return new self($domainParts, $tld);
                  Severity: Major
                  Found in src/Net/Hostname.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return new self($scheme, $host, $port, $path, $queryString, $fragment);
                    Severity: Major
                    Found in src/Net/Url.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return true;
                      Severity: Major
                      Found in src/Net/EmailAddress.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return false;
                        Severity: Major
                        Found in src/Net/Hostname.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return new self($isAbsolute, $aboveBaseLevel, $drive, $directoryParts, $filename);
                          Severity: Major
                          Found in src/System/FilePath.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return true;
                            Severity: Major
                            Found in src/Net/Url.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      return true;
                              Severity: Major
                              Found in src/Net/Hostname.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return new self($username, $host);
                                Severity: Major
                                Found in src/Net/EmailAddress.php - About 30 mins to fix

                                  Function doParse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      private static function doParse(?UrlInterface $baseUrl, string $str, ?string &$error = null): ?self
    {
        if ($baseUrl === null && $str === '') {
            $error = 'Url "" is empty.';
                                  Severity: Minor
                                  Found in src/Net/Url.php - About 25 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function validateOctets has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      private static function validateOctets(array $octets, ?string &$error): bool
    {
        if (count($octets) !== 4) {
            $error = 'IP address must consist of four octets.';
                                  Severity: Minor
                                  Found in src/Net/IPAddress.php - About 25 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language