Sign upLogin

thinkoner/thinkgo

View on GitHub
Star
cache/redis_store.go

Summary

Maintainability
B
6 hrs
Test Coverage

RedisStore has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

type RedisStore struct {
    pool   *redis.Pool // redis connection pool
    tagSet *TagSet
    prefix string
}
Severity: Minor
Found in cache/redis_store.go - About 2 hrs to fix

    Method RedisStore.deleteKeysByReference has 5 return statements (exceeds 4 allowed).
    Open

    func (s *RedisStore) deleteKeysByReference(reference string) error {
    if s.tagSet == nil {
        return nil
    }
    Severity: Major
    Found in cache/redis_store.go - About 35 mins to fix

      Method RedisStore.Flush has 5 return statements (exceeds 4 allowed).
      Open

      func (s *RedisStore) Flush() error {
    if s.tagSet != nil {
        err := s.deleteForeverKeys()
        if err != nil {
            return err
      Severity: Major
      Found in cache/redis_store.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (s *RedisStore) Increment(key string, value ...int) (int, error) {
    err := s.pushStandardKeys(key)
    if err != nil {
        return 0, err
    }
        Severity: Major
        Found in cache/redis_store.go and 1 other location - About 1 hr to fix
        cache/redis_store.go on lines 80..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (s *RedisStore) Decrement(key string, value ...int) (int, error) {
    err := s.pushStandardKeys(key)
    if err != nil {
        return 0, err
    }
        Severity: Major
        Found in cache/redis_store.go and 1 other location - About 1 hr to fix
        cache/redis_store.go on lines 62..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status