timjb/halma

Found

\ text ->
  case text of
      "N" -> pure North
      "NE" -> pure Northeast
      "SE" -> pure Southeast
      "S" -> pure South
      "SW" -> pure Southwest
      "NW" -> pure Northwest
      _ -> fail
             "expected a Halma direction (one of N, NE, SE, S, SW, NW)"

Perhaps

\case
    "N" -> pure North
    "NE" -> pure Northeast
    "SE" -> pure Southeast
    "S" -> pure South
    "SW" -> pure Southwest
    "NW" -> pure Northwest
    _ -> fail
           "expected a Halma direction (one of N, NE, SE, S, SW, NW)"

Found

(flip hlAIMove moveByAi)

Perhaps

(`hlAIMove` moveByAi)

Found

let match' = match{matchCurrentGame = Just game'}
modify $ \ chat -> chat{hcMatchState = MatchRunning match'}
sendMatchState

Perhaps

Combine with halma-telegram-bot/src/Game/Halma/TelegramBot/Controller.hs:228:7

Found

data TargetModifier
  = TargetModifier {_unTargetModifier :: Int}
  deriving (Show, Eq, Ord)

Perhaps

newtype TargetModifier
  = TargetModifier {_unTargetModifier :: Int}
  deriving (Show, Eq, Ord)

Applying this change:

• decreases laziness

Found

\ text ->
  case text of
      "allowed" -> pure Allowed
      "temporarily" -> pure Temporarily
      "forbidden" -> pure Forbidden
      _ -> fail "expected 'allowed', 'temporarily' or 'forbidden'"

Perhaps

\case
    "allowed" -> pure Allowed
    "temporarily" -> pure Temporarily
    "forbidden" -> pure Forbidden
    _ -> fail "expected 'allowed', 'temporarily' or 'forbidden'"

Applying this change:

• may require {-# LANGUAGE LambdaCase #-} adding to the top of the file

Found

PieceNumber -> [Char]

Perhaps

PieceNumber -> String

Found

(flip hlUnrecognizedCmdMsg call)

Perhaps

(`hlUnrecognizedCmdMsg` call)

Found

(flip button ButtonInactive)

Perhaps

(`button` ButtonInactive)

Found

map
  (\ (numStr, players') ->
     button (numStr ++ " Players")
       (configButtonAction (playersOnLargeGrid players')))
  $
  [("Two", TwoPlayers () ()), ("Three", ThreePlayers () () ()),
   ("Four", FourPlayers () () () ()),
   ("Five", FivePlayers () () () () ()),
   ("Six", SixPlayers () () () () () ())]

Perhaps

map
  (\ (numStr, players') ->
     button (numStr ++ " Players")
       (configButtonAction (playersOnLargeGrid players')))
  [("Two", TwoPlayers () ()), ("Three", ThreePlayers () () ()),
   ("Four", FourPlayers () () () ()),
   ("Five", FivePlayers () () () () ()),
   ("Six", SixPlayers () () () () () ())]

Found

(flip hlNotYourTurn notYourTurnInfo)

Perhaps

(`hlNotYourTurn` notYourTurnInfo)

Found

go (Just (currentMax, bestMove)) (option@(rating, move) : options)
  = if isWin rating then option else
      if newRating <= currentMax then
        go (Just (currentMax, bestMove)) options else
        if boundReached newRating then (newRating, move) else
          go (Just (newRating, move)) options
  where newRating = fst $ nextLevel option (Just currentMax)

Perhaps

go (Just (currentMax, bestMove)) (option@(rating, move) : options)
  | isWin rating = option
  | newRating <= currentMax =
    go (Just (currentMax, bestMove)) options
  | boundReached newRating = (newRating, move)
  | otherwise = go (Just (newRating, move)) options
  where newRating = fst $ nextLevel option (Just currentMax)

Found

(flip hlCantUndo Nothing)

Perhaps

(`hlCantUndo` Nothing)