Sign upLogin

tlsfuzzer/tlslite-ng

View on GitHub
Star

Showing 1,708 of 1,708 total issues

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, cipherSuite, clientHello, serverHello, privateKey,
Severity: Minor
Found in tlslite/keyexchange.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if ext.extType == ExtensionType.cookie:
                            if ext.extData != cookie.extData:
                                eType = AlertDescription.illegal_parameter
                                eText = "Malformed cookie extension"
                                for result in self._sendError(eType, eText):
    Severity: Major
    Found in tlslite/tlsconnection.py - About 45 mins to fix

      Function processClientKeyExchange has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def processClientKeyExchange(self, clientKeyExchange):
        """Decrypt client key exchange, return premaster secret"""
        premasterSecret = self.privateKey.decrypt(\
            clientKeyExchange.encryptedPreMasterSecret)
      Severity: Minor
      Found in tlslite/keyexchange.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function create has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def create(self, session_id_hit, certificate_type, server_version,
      Severity: Minor
      Found in tlslite/messages.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                for result in self._sendError(
                                AlertDescription.handshake_failure):
                            yield result
                    secureRenego = True
        Severity: Major
        Found in tlslite/tlsconnection.py - About 45 mins to fix

          Function _sockSendAll has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def _sockSendAll(self, data):
        """
        Send all data through socket

        :type data: bytearray
          Severity: Minor
          Found in tlslite/recordlayer.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _clientTLS13Handshake has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def _clientTLS13Handshake(self, settings, session, clientHello,
          Severity: Minor
          Found in tlslite/tlsconnection.py - About 45 mins to fix

            Function _server_select_certificate has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def _server_select_certificate(self, settings, client_hello,
            Severity: Minor
            Found in tlslite/tlsconnection.py - About 45 mins to fix

              Function create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def create(self, master_secret, protocol_version, cipher_suite,
               creation_time, nonce=bytearray(), client_cert_chain=None,
               encrypt_then_mac=False, extended_master_secret=False,
               server_name=bytearray()):
        """Initialise the object with cryptographic data."""
              Severity: Minor
              Found in tlslite/messages.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _clientSelectNextProto has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def _clientSelectNextProto(self, nextProtos, serverHello):
        # nextProtos is None or non-empty list of strings
        # serverHello.next_protos is None or possibly-empty list of strings
        #
        # !!! We assume the client may have specified nextProtos as a list of
              Severity: Minor
              Found in tlslite/tlsconnection.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _sendFinished has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def _sendFinished(self, masterSecret, cipherSuite=None, nextProto=None,
              Severity: Minor
              Found in tlslite/tlsconnection.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        for result in self._sendError(
                                AlertDescription.illegal_parameter,
                                "Other party's TACK doesn't match their public key"):
                                yield result
                Severity: Major
                Found in tlslite/tlsconnection.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          for result in self._sendError(
                                AlertDescription.illegal_parameter,
                                "Client sent invalid Heartbeat extension"):
                            yield result
                    heartbeat = HeartbeatExtension().create(
                  Severity: Major
                  Found in tlslite/tlsconnection.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                            for result in self._sendError(AlertDescription
                                                      .missing_extension,
                                                      "Second client hello "
                                                      "does not contain "
                                                      "cookie extension"):
                    Severity: Major
                    Found in tlslite/tlsconnection.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if cert.x509List[i].sigalg not in client_sigalgs:
                            cert_chain_ok = False
                            break
                if not cert_chain_ok:
                      Severity: Major
                      Found in tlslite/tlsconnection.py - About 45 mins to fix

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    if not ver_func(certificateVerify.signature,
                            verify_bytes,
                            padding,
                            hash_name,
                            salt_len):
                        Severity: Major
                        Found in tlslite/tlsconnection.py and 2 other locations - About 45 mins to fix
                        tlslite/tlsconnection.py on lines 3123..3131
                        tlslite/tlsrecordlayer.py on lines 890..896

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 38.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    for result in self._getMsg(ContentType.handshake, expected_msg,
                                       CertificateType.x509):
                if result in (0, 1):
                    yield result
                        Severity: Major
                        Found in tlslite/tlsconnection.py and 2 other locations - About 45 mins to fix
                        tlslite/tlsconnection.py on lines 1357..1360
                        tlslite/tlsconnection.py on lines 1375..1378

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 38.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    if not ver_func(
                    cert_verify.signature, signature_context, pad_type,
                    hash_name, salt_len):
                for result in self._sendError(
                        AlertDescription.decrypt_error,
                        Severity: Major
                        Found in tlslite/tlsrecordlayer.py and 2 other locations - About 45 mins to fix
                        tlslite/tlsconnection.py on lines 3123..3131
                        tlslite/tlsconnection.py on lines 4552..4560

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 38.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                                    if self.version >= (3, 4):
                algos_numbers = [
                    getattr(CertificateCompressionAlgorithm, algo) for algo
                    in cr_settings.certificate_compression_receive
                ]
                        Severity: Major
                        Found in tlslite/tlsconnection.py and 2 other locations - About 45 mins to fix
                        tlslite/tlsconnection.py on lines 827..834
                        tlslite/tlsconnection.py on lines 2559..2564

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 38.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 3 locations. Consider refactoring.
                        Open

                                        for result in self._getMsg(ContentType.handshake, expected_msg,
                                           CertificateType.x509):
                    if result in (0, 1):
                        yield result
                        Severity: Major
                        Found in tlslite/tlsconnection.py and 2 other locations - About 45 mins to fix
                        tlslite/tlsconnection.py on lines 1357..1360
                        tlslite/tlsconnection.py on lines 3061..3064

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 38.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language