Sign upLogin

tlsfuzzer/tlslite-ng

View on GitHub
Star

Showing 1,708 of 1,708 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def __init__(self):
        """Create instance of the object."""
        super(HRRKeyShareExtension, self).__init__(extType=ExtensionType.
                                                   key_share,
                                                   hrr=True)
Severity: Minor
Found in tlslite/extensions.py and 1 other location - About 40 mins to fix
tlslite/extensions.py on lines 1896..1901

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if clientHello.getExtension(ExtensionType.heartbeat):
            # and we want to accept it
            if settings.use_heartbeat_extension:
                extensions.append(HeartbeatExtension().create(
                    HeartbeatMode.PEER_ALLOWED_TO_SEND))
Severity: Minor
Found in tlslite/tlsconnection.py and 1 other location - About 40 mins to fix
tlslite/tlsconnection.py on lines 2927..2930

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def __init__(self):
        """Create instance of the object."""
        super(ServerKeyShareExtension, self).__init__(extType=ExtensionType.
                                                      key_share,
                                                      server=True)
Severity: Minor
Found in tlslite/extensions.py and 1 other location - About 40 mins to fix
tlslite/extensions.py on lines 1945..1950

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class SignatureAlgorithmsCertExtension(_SigListExt):
    """
    Client side list of supported signatures in certificates.

    Should be used when the signatures supported in certificates and in TLS
Severity: Minor
Found in tlslite/extensions.py and 1 other location - About 40 mins to fix
tlslite/extensions.py on lines 1415..1431

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if clientHello.getExtension(ExtensionType.heartbeat):
            if settings.use_heartbeat_extension:
                ee_extensions.append(HeartbeatExtension().create(
                    HeartbeatMode.PEER_ALLOWED_TO_SEND))
Severity: Minor
Found in tlslite/tlsconnection.py and 1 other location - About 40 mins to fix
tlslite/tlsconnection.py on lines 2358..2362

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function verify has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def verify(self, sigBytes, bytes, padding=None, hashAlg=None,
Severity: Minor
Found in tlslite/utils/ecdsakey.py - About 35 mins to fix

    Function verify_binder has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def verify_binder(client_hello, handshake_hashes, position, secret, prf,
    Severity: Minor
    Found in tlslite/handshakehelpers.py - About 35 mins to fix

      Function EMSA_PSS_verify has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def EMSA_PSS_verify(self, mHash, EM, emBits, hAlg, sLen=0):
      Severity: Minor
      Found in tlslite/utils/rsakey.py - About 35 mins to fix

        Function _create_public_dsa_key has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _create_public_dsa_key(p, q, g, y,
        Severity: Minor
        Found in tlslite/utils/keyfactory.py - About 35 mins to fix

          Function hashAndVerify has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def hashAndVerify(self, sig_bytes, data, rsaScheme=None, hAlg=None,
          Severity: Minor
          Found in tlslite/utils/eddsakey.py - About 35 mins to fix

            Function verify has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def verify(self, signature, hashData, padding=None, hashAlg=None,
            Severity: Minor
            Found in tlslite/utils/python_dsakey.py - About 35 mins to fix

              Function hashAndVerify has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def hashAndVerify(self, sigBytes, bytes, rsaScheme=None, hAlg='sha1',
              Severity: Minor
              Found in tlslite/utils/ecdsakey.py - About 35 mins to fix

                Function _replicate_value has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def _replicate_value(table, i, step, end, code):
                Severity: Minor
                Found in tlslite/utils/brotlidecpy/huffman.py - About 35 mins to fix

                  Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def __init__(self, elemLength, lengthLength, fieldName, extType,
                  Severity: Minor
                  Found in tlslite/extensions.py - About 35 mins to fix

                    Function brotli_build_huffman_table has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def brotli_build_huffman_table(
                    Severity: Minor
                    Found in tlslite/utils/brotlidecpy/huffman.py - About 35 mins to fix

                      Function parsePEMKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      def parsePEMKey(s, private=False, public=False, passwordCallback=None,
                      Severity: Minor
                      Found in tlslite/utils/keyfactory.py - About 35 mins to fix

                        Function _calcPendingStates has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def _calcPendingStates(self, cipherSuite, masterSecret,
                        Severity: Minor
                        Found in tlslite/tlsrecordlayer.py - About 35 mins to fix

                          Function _x25519_generic has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          def _x25519_generic(k, u, bits, a24, p):
                          Severity: Minor
                          Found in tlslite/utils/x25519.py - About 35 mins to fix

                            Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def __init__(self, server=False, extType=None, encExt=False,
                            Severity: Minor
                            Found in tlslite/extensions.py - About 35 mins to fix

                              Function verify has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  def verify(self, sigBytes, bytes, padding='pkcs1', hashAlg=None,
                              Severity: Minor
                              Found in tlslite/utils/rsakey.py - About 35 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language