tlsfuzzer/tlslite-ng

View on GitHub
tlslite/integration/smtp_tls.py

Summary

Maintainability
A
45 mins
Test Coverage
F
38%

Function starttls has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def starttls(self,
Severity: Minor
Found in tlslite/integration/smtp_tls.py - About 45 mins to fix

    Expected 2 blank lines, found 1
    Open

    class SMTP_TLS(SMTP):
    Severity: Minor
    Found in tlslite/integration/smtp_tls.py by pep8

    Separate top-level function and class definitions with two blank lines.

    Method definitions inside a class are separated by a single blank
    line.
    
    Extra blank lines may be used (sparingly) to separate groups of
    related functions.  Blank lines may be omitted between a bunch of
    related one-liners (e.g. a set of dummy implementations).
    
    Use blank lines in functions, sparingly, to indicate logical
    sections.
    
    Okay: def a():\n    pass\n\n\ndef b():\n    pass
    Okay: def a():\n    pass\n\n\nasync def b():\n    pass
    Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
    Okay: default = 1\nfoo = 1
    Okay: classify = 1\nfoo = 1
    
    E301: class Foo:\n    b = 0\n    def bar():\n        pass
    E302: def a():\n    pass\n\ndef b(n):\n    pass
    E302: def a():\n    pass\n\nasync def b(n):\n    pass
    E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
    E303: def a():\n\n\n\n    pass
    E304: @decorator\n\ndef a():\n    pass
    E305: def a():\n    pass\na()
    E306: def a():\n    def b():\n        pass\n    def c():\n        pass

    Trailing whitespace
    Open

                         username, password, 
    Severity: Minor
    Found in tlslite/integration/smtp_tls.py by pep8

    Trailing whitespace is superfluous.

    The warning returned varies on whether the line itself is blank,
    for easier filtering for those who want to indent their blank lines.
    
    Okay: spam(1)\n#
    W291: spam(1) \n#
    W293: class Foo(object):\n    \n    bang = 12

    There are no issues that match your filters.

    Category
    Status