Sign upLogin

tlsfuzzer/tlslite-ng

View on GitHub
Star
tlslite/integration/tlsasynciodispatchermixin.py

Summary

Maintainability
A
2 hrs
Test Coverage
C
70%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def readable(self):
        """Check if the protocol is ready for reading."""
        result = self.wants_read_event()
        return result if result is not None \
            else self.sibling_class.readable(self)
Severity: Major
Found in tlslite/integration/tlsasynciodispatchermixin.py and 1 other location - About 1 hr to fix
tlslite/integration/tlsasynciodispatchermixin.py on lines 120..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def writable(self):
        """Check if the protocol is ready for writing."""
        result = self.wants_write_event()
        return result if result is not None \
            else self.sibling_class.writable(self)
Severity: Major
Found in tlslite/integration/tlsasynciodispatchermixin.py and 1 other location - About 1 hr to fix
tlslite/integration/tlsasynciodispatchermixin.py on lines 114..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status