tlsfuzzer/tlslite-ng

View on GitHub
tlslite/integration/xmlrpcserver.py

Summary

Maintainability
A
0 mins
Test Coverage
B
82%

Test for membership should be 'not in'
Open

        if not args and not 'requestHandler' in kwargs:
Severity: Minor
Found in tlslite/integration/xmlrpcserver.py by pep8

Negative comparison should be done using "not in" and "is not".

Okay: if x not in y:\n    pass
Okay: assert (X in Y or X is Z)
Okay: if not (X in Y):\n    pass
Okay: zz = x is not y
E713: Z = not X in Y
E713: if not X.B in Y:\n    pass
E714: if not X is Y:\n    pass
E714: Z = not X.B is Y

Line too long (81 > 79 characters)
Open

    from SimpleXMLRPCServer import SimpleXMLRPCServer, SimpleXMLRPCRequestHandler
Severity: Minor
Found in tlslite/integration/xmlrpcserver.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Do not use bare 'except'
Open

        except:
Severity: Minor
Found in tlslite/integration/xmlrpcserver.py by pep8

When catching exceptions, mention specific exceptions when possible.

Okay: except Exception:
Okay: except BaseException:
E722: except:

There are no issues that match your filters.

Category
Status