tmatilai/vagrant-proxyconf

View on GitHub
lib/vagrant-proxyconf/action/base.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method disabled? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def disabled?
          enabled = @machine.config.proxy.enabled
          return true if enabled == false || enabled == ''
          return false if enabled == true

Severity: Minor
Found in lib/vagrant-proxyconf/action/base.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method skip? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def skip?
          enabled = @machine.config.proxy.enabled
          return true if enabled == false || enabled == ''
          return false if enabled == true

Severity: Minor
Found in lib/vagrant-proxyconf/action/base.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return false if enabled[app_name].has_key?(:skip) == false
Severity: Major
Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return false if enabled[app_name].has_key?(:skip) == false
    Severity: Major
    Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return enabled[app_name][:skip] == true
      Severity: Major
      Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return enabled[app_name][:enabled] == false
        Severity: Major
        Found in lib/vagrant-proxyconf/action/base.rb - About 30 mins to fix

          Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                  def call(env)
                    @machine = env[:machine]
          
                    if skip?
                      logger.info I18n.t("vagrant_proxyconf.#{config_name}.skip")
          Severity: Minor
          Found in lib/vagrant-proxyconf/action/base.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status