Sign upLogin

tom-weatherhead/thaw-parser

View on GitHub
Star

Showing 27 of 27 total issues

Function llDriver has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    private llDriver(tokenList: IToken[], parse: boolean): unknown {
        if (tokenList.length === 0) {
            throw new ParserException('Token list is empty');
        }
Severity: Minor
Found in src/ll1-parser.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File lr0-parser.ts has 405 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// tom-weatherhead/thaw-parser/src/lr0-parser.ts

import {
    createSet,
    IEqualityComparable,
Severity: Minor
Found in src/lr0-parser.ts - About 5 hrs to fix

    Function shift_reduce_driver has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

        private shift_reduce_driver(tokenList: IToken[], parse: boolean): unknown {
        if (tokenList.length === 0) {
            throw new SyntaxException('Token list is empty');
        }
    Severity: Minor
    Found in src/lr0-parser.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fillFollowSet has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        protected fillFollowSet(): void {
        // this.grammar.nonTerminals.for Each((A: GrammarSymbol) => {
        for (const A of this.grammar.nonTerminals) {
            this.followSet.set(A, createSet<GrammarSymbol>());
        }
    Severity: Minor
    Found in src/parser-base.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    export class ReduceReduceConflictException {
    // extends ExceptionBase
    public readonly message: string;
    public readonly line: number;
    public readonly column: number;
    Severity: Major
    Found in src/exceptions/reduce-reduce-conflict.ts and 4 other locations - About 3 hrs to fix
    src/exceptions/internal-error.ts on lines 5..16
    src/exceptions/parser.ts on lines 5..16
    src/exceptions/shift-reduce-conflict.ts on lines 5..16
    src/exceptions/syntax.ts on lines 5..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    export class ShiftReduceConflictException {
    // extends ExceptionBase
    public readonly message: string;
    public readonly line: number;
    public readonly column: number;
    Severity: Major
    Found in src/exceptions/shift-reduce-conflict.ts and 4 other locations - About 3 hrs to fix
    src/exceptions/internal-error.ts on lines 5..16
    src/exceptions/parser.ts on lines 5..16
    src/exceptions/reduce-reduce-conflict.ts on lines 5..16
    src/exceptions/syntax.ts on lines 5..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    export class ParserException {
    // extends ExceptionBase
    public readonly message: string;
    public readonly line: number;
    public readonly column: number;
    Severity: Major
    Found in src/exceptions/parser.ts and 4 other locations - About 3 hrs to fix
    src/exceptions/internal-error.ts on lines 5..16
    src/exceptions/reduce-reduce-conflict.ts on lines 5..16
    src/exceptions/shift-reduce-conflict.ts on lines 5..16
    src/exceptions/syntax.ts on lines 5..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    export class SyntaxException {
    // extends ExceptionBase
    public readonly message: string;
    public readonly line: number;
    public readonly column: number;
    Severity: Major
    Found in src/exceptions/syntax.ts and 4 other locations - About 3 hrs to fix
    src/exceptions/internal-error.ts on lines 5..16
    src/exceptions/parser.ts on lines 5..16
    src/exceptions/reduce-reduce-conflict.ts on lines 5..16
    src/exceptions/shift-reduce-conflict.ts on lines 5..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    export class InternalErrorException {
    // extends ExceptionBase
    public readonly message: string;
    public readonly line: number;
    public readonly column: number;
    Severity: Major
    Found in src/exceptions/internal-error.ts and 4 other locations - About 3 hrs to fix
    src/exceptions/parser.ts on lines 5..16
    src/exceptions/reduce-reduce-conflict.ts on lines 5..16
    src/exceptions/shift-reduce-conflict.ts on lines 5..16
    src/exceptions/syntax.ts on lines 5..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function llDriver has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private llDriver(tokenList: IToken[], parse: boolean): unknown {
        if (tokenList.length === 0) {
            throw new ParserException('Token list is empty');
        }
    Severity: Major
    Found in src/ll1-parser.ts - About 3 hrs to fix

      Function shift_reduce_driver has 82 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private shift_reduce_driver(tokenList: IToken[], parse: boolean): unknown {
        if (tokenList.length === 0) {
            throw new SyntaxException('Token list is empty');
        }
      Severity: Major
      Found in src/lr0-parser.ts - About 3 hrs to fix

        Function GetAction has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            private GetAction(S: CFSMState): {
        reduceProductionNum: number;
        action: ShiftReduceAction;
    } {
        let result = ShiftReduceAction.Error;
        Severity: Minor
        Found in src/lr0-parser.ts - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function computeFirst has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            protected computeFirst(alpha: GrammarSymbol[]): ISet<GrammarSymbol> {
        const k = alpha.length;
        const result = createSet<GrammarSymbol>();

        if (k === 0 || (k === 1 && alpha[0] === GrammarSymbol.Lambda)) {
        Severity: Minor
        Found in src/parser-base.ts - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function closure0 has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            private closure0(s: IImmutableSet<LR0Configuration>): ISet<LR0Configuration> {
        const sPrime = createSet<LR0Configuration>(s);
        const additions = createSet<LR0Configuration>();

        do {
        Severity: Minor
        Found in src/lr0-parser.ts - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function fillFirstSet has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

            protected fillFirstSet(): void {
        for (const A of this.grammar.nonTerminals) {
            const s = createSet<GrammarSymbol>();

            if (this.derivesLambda.contains(A)) {
        Severity: Minor
        Found in src/parser-base.ts - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function fillFollowSet has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected fillFollowSet(): void {
        // this.grammar.nonTerminals.for Each((A: GrammarSymbol) => {
        for (const A of this.grammar.nonTerminals) {
            this.followSet.set(A, createSet<GrammarSymbol>());
        }
        Severity: Minor
        Found in src/parser-base.ts - About 1 hr to fix

          Function computeFirst has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected computeFirst(alpha: GrammarSymbol[]): ISet<GrammarSymbol> {
        const k = alpha.length;
        const result = createSet<GrammarSymbol>();

        if (k === 0 || (k === 1 && alpha[0] === GrammarSymbol.Lambda)) {
          Severity: Minor
          Found in src/parser-base.ts - About 1 hr to fix

            Function GetAction has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private GetAction(S: CFSMState): {
        reduceProductionNum: number;
        action: ShiftReduceAction;
    } {
        let result = ShiftReduceAction.Error;
            Severity: Minor
            Found in src/lr0-parser.ts - About 1 hr to fix

              Function fillFirstSet has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected fillFirstSet(): void {
        for (const A of this.grammar.nonTerminals) {
            const s = createSet<GrammarSymbol>();

            if (this.derivesLambda.contains(A)) {
              Severity: Minor
              Found in src/parser-base.ts - About 1 hr to fix

                Function build_CFSM has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    private build_CFSM(): CharacteristicFiniteStateMachine {
        const s0 = this.compute_s0();
        const startState = new CFSMState(s0);
        const cfsm = new CharacteristicFiniteStateMachine(startState);
        const S = new Stack<ISet<LR0Configuration>>();
                Severity: Minor
                Found in src/lr0-parser.ts - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language