Sign upLogin

topfreegames/khan

View on GitHub
Star

Showing 425 of 425 total issues

Function ApproveOrDenyMembershipApplication has 12 return statements (exceeds 4 allowed).
Open

func ApproveOrDenyMembershipApplication(db DB, encryptionKey []byte, game *Game, gameID, playerPublicID, clanPublicID, requestorPublicID, action string) (*Membership, error) {
    if playerPublicID == requestorPublicID {
        return nil, &PlayerCannotPerformMembershipActionError{action, playerPublicID, clanPublicID, requestorPublicID}
    }
Severity: Major
Found in models/membership.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            It("should load all games", func() {
            game := fixtures.GameFactory.MustCreate().(*models.Game)
            err := testDb.Insert(game)
            Expect(err).NotTo(HaveOccurred())
    Severity: Major
    Found in api/app_test.go and 1 other location - About 1 hr to fix
    api/app_test.go on lines 91..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if err != nil {
            log.E(logger, "Updating player failed.", func(cm log.CM) {
                cm.Write(zap.Error(err))
            })
    Severity: Major
    Found in api/player.go and 1 other location - About 1 hr to fix
    api/player.go on lines 57..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            It("should get game by Public ID", func() {
            game := fixtures.GameFactory.MustCreate().(*models.Game)
            err := testDb.Insert(game)
            Expect(err).NotTo(HaveOccurred())
    Severity: Major
    Found in api/app_test.go and 1 other location - About 1 hr to fix
    api/app_test.go on lines 79..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if err != nil {
            log.E(logger, "Player creation failed.", func(cm log.CM) {
                cm.Write(zap.Error(err))
            })
    Severity: Major
    Found in api/player.go and 1 other location - About 1 hr to fix
    api/player.go on lines 160..170

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function LeaveClan has 54 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func LeaveClan(db DB, encryptionKey []byte, gameID, publicID string) (*Clan, *Player, *Player, error) {
    clan, err := GetClanByPublicID(db, gameID, publicID)
    if err != nil {
        return nil, nil, nil, err
    }
    Severity: Minor
    Found in models/clan.go - About 1 hr to fix

      Function dispatchApproveDenyMembershipHook has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func dispatchApproveDenyMembershipHook(app *App, db models.DB, hookType int, gameID string, clan *models.Clan, player *models.Player, requestor *models.Player, creator *models.Player, message, playerMembershipLevel string) error {
      Severity: Major
      Found in api/membership_helpers.go - About 1 hr to fix

        Function inviteMember has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func inviteMember(db DB, encryptionKey []byte, game *Game, membership *Membership, level string, clan *Clan, playerID int64, requestorPublicID, message string, previousMembership bool) (*Membership, error) {
        Severity: Major
        Found in models/membership.go - About 1 hr to fix

          Function PruneStaleData has 53 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func PruneStaleData(options *PruneOptions, db DB, logger zap.Logger) (*PruneStats, error) {
    log.I(logger, "Pruning stale data...", func(cm log.CM) {
        cm.Write(
            zap.String("GameID", options.GameID),
            zap.Int("PendingApplicationsExpiration", options.PendingApplicationsExpiration),
          Severity: Minor
          Found in models/prune.go - About 1 hr to fix

            Function easyjsonA8a797f8DecodeGithubComTopfreegamesKhanApi7 has 53 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func easyjsonA8a797f8DecodeGithubComTopfreegamesKhanApi7(in *jlexer.Lexer, out *CreatePlayerPayload) {
    isTopLevel := in.IsStart()
    if in.IsNull() {
        if isTopLevel {
            in.Consumed()
            Severity: Minor
            Found in api/payload_easyjson.go - About 1 hr to fix

              Function LeaveClanHandler has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
              Open

              func LeaveClanHandler(app *App) func(c echo.Context) error {
    return func(c echo.Context) error {
        c.Set("route", "LeaveClan")
        start := time.Now()
        gameID := c.Param("gameID")
              Severity: Minor
              Found in api/clan.go - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 7 locations. Consider refactoring.
              Open

              func (m *MockKhanInterface) ApproveDenyMembershipApplication(arg0 context.Context, arg1 *lib.ApplicationApprovalPayload) (*lib.Result, error) {
    m.ctrl.T.Helper()
    ret := m.ctrl.Call(m, "ApproveDenyMembershipApplication", arg0, arg1)
    ret0, _ := ret[0].(*lib.Result)
    ret1, _ := ret[1].(error)
              Severity: Major
              Found in lib/mocks/khan.go and 6 other locations - About 1 hr to fix
              lib/mocks/khan.go on lines 38..44
              lib/mocks/khan.go on lines 68..74
              lib/mocks/khan.go on lines 113..119
              lib/mocks/khan.go on lines 128..134
              lib/mocks/khan.go on lines 158..164
              lib/mocks/khan.go on lines 263..269

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 7 locations. Consider refactoring.
              Open

              func (m *MockKhanInterface) PromoteDemote(arg0 context.Context, arg1 *lib.PromoteDemotePayload) (*lib.Result, error) {
    m.ctrl.T.Helper()
    ret := m.ctrl.Call(m, "PromoteDemote", arg0, arg1)
    ret0, _ := ret[0].(*lib.Result)
    ret1, _ := ret[1].(error)
              Severity: Major
              Found in lib/mocks/khan.go and 6 other locations - About 1 hr to fix
              lib/mocks/khan.go on lines 38..44
              lib/mocks/khan.go on lines 53..59
              lib/mocks/khan.go on lines 68..74
              lib/mocks/khan.go on lines 113..119
              lib/mocks/khan.go on lines 128..134
              lib/mocks/khan.go on lines 263..269

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          for _, expectedClan := range expectedClans {
                clan := clansDict[expectedClan.PublicID]
                Expect(clan["name"]).To(Equal(expectedClan.Name))
                Expect(clan["membershipCount"].(float64)).To(BeEquivalentTo(expectedClan.MembershipCount))
                Expect(clan["autoJoin"]).To(Equal(expectedClan.AutoJoin))
              Severity: Major
              Found in api/clan_test.go and 1 other location - About 1 hr to fix
              api/clan_test.go on lines 1163..1169

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 7 locations. Consider refactoring.
              Open

              func (m *MockKhanInterface) ApplyForMembership(arg0 context.Context, arg1 *lib.ApplicationPayload) (*lib.ClanApplyResult, error) {
    m.ctrl.T.Helper()
    ret := m.ctrl.Call(m, "ApplyForMembership", arg0, arg1)
    ret0, _ := ret[0].(*lib.ClanApplyResult)
    ret1, _ := ret[1].(error)
              Severity: Major
              Found in lib/mocks/khan.go and 6 other locations - About 1 hr to fix
              lib/mocks/khan.go on lines 53..59
              lib/mocks/khan.go on lines 68..74
              lib/mocks/khan.go on lines 113..119
              lib/mocks/khan.go on lines 128..134
              lib/mocks/khan.go on lines 158..164
              lib/mocks/khan.go on lines 263..269

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 7 locations. Consider refactoring.
              Open

              func (m *MockKhanInterface) ApproveDenyMembershipInvitation(arg0 context.Context, arg1 *lib.InvitationApprovalPayload) (*lib.Result, error) {
    m.ctrl.T.Helper()
    ret := m.ctrl.Call(m, "ApproveDenyMembershipInvitation", arg0, arg1)
    ret0, _ := ret[0].(*lib.Result)
    ret1, _ := ret[1].(error)
              Severity: Major
              Found in lib/mocks/khan.go and 6 other locations - About 1 hr to fix
              lib/mocks/khan.go on lines 38..44
              lib/mocks/khan.go on lines 53..59
              lib/mocks/khan.go on lines 113..119
              lib/mocks/khan.go on lines 128..134
              lib/mocks/khan.go on lines 158..164
              lib/mocks/khan.go on lines 263..269

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 7 locations. Consider refactoring.
              Open

              func (m *MockKhanInterface) UpdateClan(arg0 context.Context, arg1 *lib.ClanPayload) (*lib.Result, error) {
    m.ctrl.T.Helper()
    ret := m.ctrl.Call(m, "UpdateClan", arg0, arg1)
    ret0, _ := ret[0].(*lib.Result)
    ret1, _ := ret[1].(error)
              Severity: Major
              Found in lib/mocks/khan.go and 6 other locations - About 1 hr to fix
              lib/mocks/khan.go on lines 38..44
              lib/mocks/khan.go on lines 53..59
              lib/mocks/khan.go on lines 68..74
              lib/mocks/khan.go on lines 113..119
              lib/mocks/khan.go on lines 128..134
              lib/mocks/khan.go on lines 158..164

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          for _, expectedClan := range expectedClans {
                clan := clansDict[expectedClan.PublicID]
                Expect(clan["name"]).To(Equal(expectedClan.Name))
                Expect(clan["membershipCount"].(float64)).To(BeEquivalentTo(expectedClan.MembershipCount))
                Expect(clan["autoJoin"]).To(Equal(expectedClan.AutoJoin))
              Severity: Major
              Found in api/clan_test.go and 1 other location - About 1 hr to fix
              api/clan_test.go on lines 1100..1106

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 7 locations. Consider refactoring.
              Open

              func (m *MockKhanInterface) InviteForMembership(arg0 context.Context, arg1 *lib.InvitationPayload) (*lib.Result, error) {
    m.ctrl.T.Helper()
    ret := m.ctrl.Call(m, "InviteForMembership", arg0, arg1)
    ret0, _ := ret[0].(*lib.Result)
    ret1, _ := ret[1].(error)
              Severity: Major
              Found in lib/mocks/khan.go and 6 other locations - About 1 hr to fix
              lib/mocks/khan.go on lines 38..44
              lib/mocks/khan.go on lines 53..59
              lib/mocks/khan.go on lines 68..74
              lib/mocks/khan.go on lines 113..119
              lib/mocks/khan.go on lines 158..164
              lib/mocks/khan.go on lines 263..269

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 7 locations. Consider refactoring.
              Open

              func (m *MockKhanInterface) DeleteMembership(arg0 context.Context, arg1 *lib.DeleteMembershipPayload) (*lib.Result, error) {
    m.ctrl.T.Helper()
    ret := m.ctrl.Call(m, "DeleteMembership", arg0, arg1)
    ret0, _ := ret[0].(*lib.Result)
    ret1, _ := ret[1].(error)
              Severity: Major
              Found in lib/mocks/khan.go and 6 other locations - About 1 hr to fix
              lib/mocks/khan.go on lines 38..44
              lib/mocks/khan.go on lines 53..59
              lib/mocks/khan.go on lines 68..74
              lib/mocks/khan.go on lines 128..134
              lib/mocks/khan.go on lines 158..164
              lib/mocks/khan.go on lines 263..269

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language