topfreegames/khan

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        It("Should not update clan if invalid payload", func() {
            route := GetGameRoute("game-id", fmt.Sprintf("/clans/%s", "random-id"))

            status, body := Put(app, route, "invalid")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        It("Should not update player if missing parameters", func() {
            route := GetGameRoute("game-id", "/players/player-id")
            status, body := PutJSON(a, route, map[string]interface{}{})

            Expect(status).To(Equal(http.StatusBadRequest))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        It("Should not create player if missing parameters", func() {
            route := GetGameRoute("game-id", "/players")
            status, body := PostJSON(a, route, map[string]interface{}{})

            Expect(status).To(Equal(http.StatusBadRequest))

• Read up
  Read up

Function easyjsonA8a797f8DecodeGithubComTopfreegamesKhanApi3 has 57 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func easyjsonA8a797f8DecodeGithubComTopfreegamesKhanApi3(in *jlexer.Lexer, out *UpdateClanPayload) {
    isTopLevel := in.IsStart()
    if in.IsNull() {
        if isTopLevel {
            in.Consumed()

Function LeaveClan has 13 return statements (exceeds 4 allowed).

Open

func LeaveClan(db DB, encryptionKey []byte, gameID, publicID string) (*Clan, *Player, *Player, error) {
    clan, err := GetClanByPublicID(db, gameID, publicID)
    if err != nil {
        return nil, nil, nil, err
    }

Function GetTestPlayerWithMemberships has 13 return statements (exceeds 4 allowed).

Open

func GetTestPlayerWithMemberships(db models.DB, gameID string, approvedMemberships, rejectedMemberships, bannedMemberships, pendingMemberships int) (*models.Player, *models.Player, error) {
    if gameID == "" {
        gameID = uuid.NewV4().String()
    }
    game := GameFactory.MustCreateWithOption(map[string]interface{}{

Function TransferClanOwnership has 13 return statements (exceeds 4 allowed).

Open

func TransferClanOwnership(db DB, encryptionKey []byte, gameID, clanPublicID, playerPublicID string, levels map[string]interface{}, maxLevel int) (*Clan, *Player, *Player, error) {
    clan, err := GetClanByPublicID(db, gameID, clanPublicID)
    if err != nil {
        return nil, nil, nil, err
    }

Function easyjsonA8a797f8EncodeGithubComTopfreegamesKhanApi9 has 56 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func easyjsonA8a797f8EncodeGithubComTopfreegamesKhanApi9(out *jwriter.Writer, in CreateClanPayload) {
    out.RawByte('{')
    first := true
    _ = first
    {

Function validateMembership has 56 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func validateMembership(db DB, encryptionKey []byte, game *Game, membership *Membership, clan *Clan, playerPublicID, requestorPublicID string) (int64, bool, error) {
    playerID := int64(-1)
    previousMembership := false
    if membership != nil {
        previousMembership = true

Function createClanPlayers has 56 lines of code (exceeds 50 allowed). Consider refactoring.

Open

func createClanPlayers(db models.DB, games []string, clans map[string][]clanData, playersPerClan int, approved, denied, banned bool, progress func() bool) {
    for _, game := range games {
        for _, clan := range clans[game] {
            sql := `
            WITH addedPlayers AS (

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        It("Should not approve membership application if missing parameters", func() {
            status, body := PostJSON(a, CreateMembershipRoute("gameID", "clanPublicID", "application/approve"), map[string]interface{}{})

            Expect(status).To(Equal(http.StatusBadRequest))
            var result map[string]interface{}

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        It("Should not promote member if missing parameters", func() {
            status, body := PostJSON(a, CreateMembershipRoute("gameID", "clanPublicID", "promote"), map[string]interface{}{})

            Expect(status).To(Equal(http.StatusBadRequest))
            var result map[string]interface{}

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        It("Should not create membership application if missing parameters", func() {
            status, body := PostJSON(a, CreateMembershipRoute("gameID", "clanPublicID", "application"), map[string]interface{}{})

            Expect(status).To(Equal(http.StatusBadRequest))
            var result map[string]interface{}

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        It("Should not create membership invitation if missing parameters", func() {
            status, body := PostJSON(a, CreateMembershipRoute("gameID", "clanPublicID", "invitation"), map[string]interface{}{})

            Expect(status).To(Equal(http.StatusBadRequest))
            var result map[string]interface{}

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        It("Should not approve membership invitation if missing parameters", func() {
            status, body := PostJSON(a, CreateMembershipRoute("gameID", "clanPublicID", "invitation/approve"), map[string]interface{}{})

            Expect(status).To(Equal(http.StatusBadRequest))
            var result map[string]interface{}

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        It("Should not delete member if missing parameters", func() {
            status, body := PostJSON(a, CreateMembershipRoute("gameID", "clanPublicID", "delete"), map[string]interface{}{})

            Expect(status).To(Equal(http.StatusBadRequest))
            var result map[string]interface{}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        It("Should not update player if invalid payload", func() {
            route := GetGameRoute("game-id", "/players/fake")
            status, body := Put(a, route, "invalid")

            Expect(status).To(Equal(http.StatusBadRequest))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        It("Should not create player if invalid payload", func() {
            route := GetGameRoute("game-id", "/players")
            status, body := Post(a, route, "invalid")

            Expect(status).To(Equal(http.StatusBadRequest))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if p.ApproverPublicID.Valid {
        if p.DBApproverMetadata.Valid {
            json.Unmarshal([]byte(nullOrString(p.DBApproverMetadata)), &p.ApproverMetadata)
        } else {
            p.ApproverMetadata = map[string]interface{}{}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if p.DenierPublicID.Valid {
        if p.DBDenierMetadata.Valid {
            json.Unmarshal([]byte(nullOrString(p.DBDenierMetadata)), &p.DenierMetadata)
        } else {
            p.DenierMetadata = map[string]interface{}{}

• Read up
  Read up