Sign upLogin

trailofbits/tubertc

View on GitHub
Star

Showing 226 of 226 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        } else {
            hangoutsViewport.elem.css({ height: '100%', 'padding-bottom': 0 });

            dashboard.rowArray[0].css({
                width: '80%',
Severity: Major
Found in public/js/viewports.js and 1 other location - About 2 hrs to fix
public/js/viewports.js on lines 386..397

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (dashboard.orientation === 'landscape') {
            hangoutsViewport.elem.css({ width: '100%', 'padding-right': 0 });

            dashboard.rowArray[0].css({
                height: '85%',
Severity: Major
Found in public/js/viewports.js and 1 other location - About 2 hrs to fix
public/js/viewports.js on lines 397..408

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            NavBar.cameraBtn.handle(function() {
                client.enableCamera(true);
                sendMediaPresence(client, 'camera', true);

                viewport.showCamera(true);
Severity: Major
Found in public/js/room.js and 1 other location - About 2 hrs to fix
public/js/room.js on lines 322..332

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            NavBar.micBtn.handle(function() {
                client.enableMicrophone(true);
                sendMediaPresence(client, 'mic', true);

                viewport.showMic(true);
Severity: Major
Found in public/js/room.js and 1 other location - About 2 hrs to fix
public/js/room.js on lines 309..319

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function StatefulButton has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

var StatefulButton = function(id, selected) {
    var idSel = $(id);
    var _kSelectedColor = '#009966';
    var _kUnselectedColor = '#cc0033';
    var _buttonIsEnabled = true;
Severity: Minor
Found in public/js/navbar.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Button has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Button = function(id) {
    var idSel = $(id);
    var _kDefaultColor = '#cccccc';
    var _kDisabledColor = '#404040';
    var _buttonIsEnabled = true;
Severity: Minor
Found in public/js/navbar.js - About 1 hr to fix

    Function has a complexity of 11.
    Open

            .onPeerMessage(function(client, peerId, msgType, content) {
    Severity: Minor
    Found in public/js/room.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function Listener has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        Listener: function() {
        this.handlePeerMessage = function(client, peerId, content) {
            if (typeof content.opcode === 'string') {
                if (content.opcode === 'testP2PConnection' &&
                    typeof content.id === 'number') {
    Severity: Minor
    Found in public/telemetry/debug.js - About 1 hr to fix

      Function placeViewports has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          this.placeViewports = function() {
        var layout;

        if (this.hangoutsMode) {
            layout = this.gridForHangoutsMode();
      Severity: Minor
      Found in public/js/viewports.js - About 1 hr to fix

        Function _checkIfNonTlsAndChromeAbove47 has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            _checkIfNonTlsAndChromeAbove47: function() {
        var userAgent = navigator.userAgent;
        if (window.location.protocol !== 'https:' &&
            (window.location.hostname !== 'localhost' && window.location.hostname !== '127.0.0.1')) {
            var browserString = null;
        Severity: Minor
        Found in public/js/login.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function vtcMain has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        var vtcMain = function(params) {
    // @todo XXX(debug): If debugging mode is enabled (DebugConsole is a valid function),
    // instantiate a new instance of DebugConsole
    var dbgListener = null;
    if (typeof DebugConsole === 'object' && typeof DebugConsole.Listener === 'function') {
        Severity: Minor
        Found in public/js/room.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function Client has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            Client: function() {
        /**
         * Gets the room list associated with the VTC client.
         *
         * @returns {Array<String>} An array of peerIDs
        Severity: Minor
        Found in public/telemetry/debug.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handlePeerMessage has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                this.handlePeerMessage = function(client, peerId, content) {
            if (typeof content.opcode === 'string') {
                if (content.opcode === 'testP2PConnection' &&
                    typeof content.id === 'number') {
                    var roomList = DebugConsole._getRoomUserList();
        Severity: Minor
        Found in public/telemetry/debug.js - About 1 hr to fix

          Function create has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              create: function(peerId, stream, meterFillElem, isLocalStream) {
        var _this = this;
        var audioContext = null;
        var mediaStreamSource = null;
        var processor = null;
          Severity: Minor
          Found in public/js/audiometer.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            var MicToggle = function() {
    this.command = 'mic';

    this.help = _toggleCmdHelp(this, 'microphone');
    this.execute = _toggleCmdExecute(this, 'Microphone', NavBar.micBtn);
            Severity: Major
            Found in public/js/chat-cmds.js and 1 other location - About 1 hr to fix
            public/js/chat-cmds.js on lines 175..182

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            var CameraToggle = function() {
    this.command = 'camera';

    this.help = _toggleCmdHelp(this, 'camera');
    this.execute = _toggleCmdExecute(this, 'Camera', NavBar.cameraBtn);
            Severity: Major
            Found in public/js/chat-cmds.js and 1 other location - About 1 hr to fix
            public/js/chat-cmds.js on lines 189..196

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function create has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                create: function(peerId, stream, meterFillElem, isLocalStream) {
        var _this = this;
        var audioContext = null;
        var mediaStreamSource = null;
        var processor = null;
            Severity: Minor
            Found in public/js/audiometer.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function gridForViewportNumber has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                this.gridForViewportNumber = function(viewports) {
        if(viewports === 0) {
            return { 
                rows: 0, 
                grid: []
            Severity: Minor
            Found in public/js/viewports.js - About 1 hr to fix

              Function sendPeerMessage has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  this.sendPeerMessage = function(dest, msgType, msgData, successFn) {
        var target = {};
        if (typeof dest !== 'object' ||
            (typeof dest.rtcId !== 'string' && typeof dest.room !== 'string')) {
            ErrorMetric.log('VTCClient.sendPeerMessage => dest object is invalid');
              Severity: Minor
              Found in public/js/vtc.js - About 1 hr to fix

                Function handleCommand has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    handleCommand: function(message) {
        if (!message.length) {
            ErrorMetric.log('ChatCommands.handleCommand => message too small');
            ErrorMetric.log('                              msg: "' + message + '"');
            return false;
                Severity: Minor
                Found in public/js/chat-cmds.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language