Showing 20 of 29 total issues
File FootprintService.js
has 299 lines of code (exceeds 250 allowed). Consider refactoring. Open
'use strict'
const _ = require('lodash')
const Service = require('trails/lib/Service')
const ModelError = require('../../lib').ModelError
Function transformModels
has 59 lines of code (exceeds 25 allowed). Consider refactoring. Open
transformModels (app) {
// const models = app.models
return _.mapValues(app.models, (model, modelName) => {
Function updateAssociation
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
updateAssociation(parentModelName, parentId, childAttributeName, criteria, values, options) {
const parentModel = this._getModel(parentModelName)
if (!parentModel) {
return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
}
Function findAssociation
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
findAssociation(parentModelName, parentId, childAttributeName, criteria, options) {
const parentModel = this._getModel(parentModelName)
if (!parentModel) {
return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
}
Function find
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
find(modelName, criteria, options) {
const Model = this._getModel(modelName)
const modelOptions = _.defaultsDeep({}, options, _.get(this.app.config, 'footprints.models.options'))
let query
if (!Model) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function initialize
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
initialize() {
super.initialize()
this.orm = this.orm || {}
this.app.orm = {}
Function findAssociation
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
findAssociation(parentModelName, parentId, childAttributeName, criteria, options) {
const parentModel = this._getModel(parentModelName)
if (!parentModel) {
return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function updateAssociation
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
updateAssociation(parentModelName, parentId, childAttributeName, criteria, values, options) {
const parentModel = this._getModel(parentModelName)
if (!parentModel) {
return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function find
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
find(modelName, criteria, options) {
const Model = this._getModel(modelName)
const modelOptions = _.defaultsDeep({}, options, _.get(this.app.config, 'footprints.models.options'))
let query
if (!Model) {
Function createAssociation
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
createAssociation(parentModelName, parentId, childAttributeName, values, options) {
const parentModel = this._getModel(parentModelName)
if (!parentModel) {
return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
}
Function destroy
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
destroy(modelName, criteria, options) {
const Model = this._getModel(modelName)
if (!options) options = {}
let query
if (!Model) {
Function update
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
update(modelName, criteria, values, options) {
const Model = this._getModel(modelName)
if (!options) options = {}
if (!Model) {
return Promise.reject(new ModelError('E_NOT_FOUND', `${modelName} can't be found`))
Function destroy
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
destroy(modelName, criteria, options) {
const Model = this._getModel(modelName)
if (!options) options = {}
let query
if (!Model) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function update
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
update(modelName, criteria, values, options) {
const Model = this._getModel(modelName)
if (!options) options = {}
if (!Model) {
return Promise.reject(new ModelError('E_NOT_FOUND', `${modelName} can't be found`))
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return this._getThroughModelAssociation(association, parentId)
.then(ids => childModel.update(values, _.extend({
where: {
$and: [
criteria || {},
Avoid too many return
statements within this function. Open
return this.find(parentModelName, parentId)
.then(parent => this.find(childModelName, parent[association.identifierField], options))
Avoid too many return
statements within this function. Open
return this.find(parentModelName, parentId)
.then(parent => this.update(childModelName, parent[association.identifierField], values, options))
Avoid too many return
statements within this function. Open
return this._getThroughModelAssociation(association, parentId)
.then(ids => childModel.findAll(_.extend({
where: {
$and: [
criteria || {},
Function createAssociation
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
createAssociation(parentModelName, parentId, childAttributeName, values, options) {
const parentModel = this._getModel(parentModelName)
if (!parentModel) {
return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function transformModels
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
transformModels (app) {
// const models = app.models
return _.mapValues(app.models, (model, modelName) => {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"