Sign upLogin

trailsjs/trailpack-sequelize

View on GitHub
Star

Showing 29 of 29 total issues

File FootprintService.js has 299 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'

const _ = require('lodash')
const Service = require('trails/lib/Service')
const ModelError = require('../../lib').ModelError
Severity: Minor
Found in api/services/FootprintService.js - About 3 hrs to fix

    Function transformModels has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      transformModels (app) {

    // const models = app.models

    return _.mapValues(app.models, (model, modelName) => {
    Severity: Major
    Found in lib/transformer.js - About 2 hrs to fix

      Function updateAssociation has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        updateAssociation(parentModelName, parentId, childAttributeName, criteria, values, options) {
    const parentModel = this._getModel(parentModelName)
    if (!parentModel) {
      return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
    }
      Severity: Minor
      Found in api/services/FootprintService.js - About 1 hr to fix

        Function findAssociation has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          findAssociation(parentModelName, parentId, childAttributeName, criteria, options) {
    const parentModel = this._getModel(parentModelName)
    if (!parentModel) {
      return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
    }
        Severity: Minor
        Found in api/services/FootprintService.js - About 1 hr to fix

          Function find has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

            find(modelName, criteria, options) {
    const Model = this._getModel(modelName)
    const modelOptions = _.defaultsDeep({}, options, _.get(this.app.config, 'footprints.models.options'))
    let query
    if (!Model) {
          Severity: Minor
          Found in api/services/FootprintService.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            validateStoresConfig (config) {
    return new Promise((resolve, reject) => {
      joi.validate(config, lib.Schemas.storesConfig, (err, value) => {
        if (err) return reject(err)
          Severity: Major
          Found in lib/validator.js and 1 other location - About 1 hr to fix
          lib/validator.js on lines 14..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            validateModelsConfig (config) {
    return new Promise((resolve, reject) => {
      joi.validate(config, lib.Schemas.modelsConfig, (err, value) => {
        if (err) return reject(err)
          Severity: Major
          Found in lib/validator.js and 1 other location - About 1 hr to fix
          lib/validator.js on lines 5..13

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function initialize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            initialize() {
    super.initialize()

    this.orm = this.orm || {}
    this.app.orm = {}
          Severity: Minor
          Found in index.js - About 1 hr to fix

            Function findAssociation has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

              findAssociation(parentModelName, parentId, childAttributeName, criteria, options) {
    const parentModel = this._getModel(parentModelName)
    if (!parentModel) {
      return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
    }
            Severity: Minor
            Found in api/services/FootprintService.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function updateAssociation has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

              updateAssociation(parentModelName, parentId, childAttributeName, criteria, values, options) {
    const parentModel = this._getModel(parentModelName)
    if (!parentModel) {
      return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
    }
            Severity: Minor
            Found in api/services/FootprintService.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function find has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              find(modelName, criteria, options) {
    const Model = this._getModel(modelName)
    const modelOptions = _.defaultsDeep({}, options, _.get(this.app.config, 'footprints.models.options'))
    let query
    if (!Model) {
            Severity: Minor
            Found in api/services/FootprintService.js - About 1 hr to fix

              Function createAssociation has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                createAssociation(parentModelName, parentId, childAttributeName, values, options) {
    const parentModel = this._getModel(parentModelName)
    if (!parentModel) {
      return Promise.reject(new ModelError('E_NOT_FOUND', `${parentModelName} can't be found`))
    }
              Severity: Minor
              Found in api/services/FootprintService.js - About 1 hr to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    if (_.isArray(options.populate) || _.isPlainObject(options.populate)) {
      options.include = options.populate
      delete options.populate
    }
                Severity: Major
                Found in api/services/FootprintService.js and 2 other locations - About 1 hr to fix
                api/services/FootprintService.js on lines 140..143
                api/services/FootprintService.js on lines 189..192

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    if (_.isArray(options.populate) || _.isPlainObject(options.populate)) {
      options.include = options.populate
      delete options.populate
    }
                Severity: Major
                Found in api/services/FootprintService.js and 2 other locations - About 1 hr to fix
                api/services/FootprintService.js on lines 180..183
                api/services/FootprintService.js on lines 189..192

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                      if (_.isArray(options.populate) || _.isPlainObject(options.populate)) {
        criteria.include = options.populate
        delete options.populate
      }
                Severity: Major
                Found in api/services/FootprintService.js and 2 other locations - About 1 hr to fix
                api/services/FootprintService.js on lines 140..143
                api/services/FootprintService.js on lines 180..183

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function destroy has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  destroy(modelName, criteria, options) {
    const Model = this._getModel(modelName)
    if (!options) options = {}
    let query
    if (!Model) {
                Severity: Minor
                Found in api/services/FootprintService.js - About 1 hr to fix

                  Function update has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    update(modelName, criteria, values, options) {
    const Model = this._getModel(modelName)
    if (!options) options = {}
    if (!Model) {
      return Promise.reject(new ModelError('E_NOT_FOUND', `${modelName} can't be found`))
                  Severity: Minor
                  Found in api/services/FootprintService.js - About 1 hr to fix

                    Function destroy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                      destroy(modelName, criteria, options) {
    const Model = this._getModel(modelName)
    if (!options) options = {}
    let query
    if (!Model) {
                    Severity: Minor
                    Found in api/services/FootprintService.js - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      update(modelName, criteria, values, options) {
    const Model = this._getModel(modelName)
    if (!options) options = {}
    if (!Model) {
      return Promise.reject(new ModelError('E_NOT_FOUND', `${modelName} can't be found`))
                    Severity: Minor
                    Found in api/services/FootprintService.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            migrate: {
          enumerable: false,
          value: configOverrides.migrate || config.migrate || app.config.get('models.migrate'),
          writable: false
        },
                    Severity: Minor
                    Found in lib/transformer.js and 1 other location - About 40 mins to fix
                    lib/transformer.js on lines 50..54

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 49.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language