Sign upLogin

treasure-data/embulk-input-zendesk

View on GitHub
Star

Showing 49 of 49 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            @Override
            public void booleanColumn(final Column column)
            {
                final JsonNode data = record.get(column.getName());
Severity: Major
Found in src/main/java/org/embulk/input/zendesk/RecordImporter.java and 3 other locations - About 35 mins to fix
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 45..54
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 83..92
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 94..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            @Override
            public void doubleColumn(final Column column)
            {
                final JsonNode data = record.get(column.getName());
Severity: Major
Found in src/main/java/org/embulk/input/zendesk/RecordImporter.java and 3 other locations - About 35 mins to fix
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 45..54
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 72..81
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            @Override
            public void longColumn(final Column column)
            {
                final JsonNode data = record.get(column.getName());
Severity: Major
Found in src/main/java/org/embulk/input/zendesk/RecordImporter.java and 3 other locations - About 35 mins to fix
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 45..54
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 72..81
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 94..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            @Override
            public void stringColumn(final Column column)
            {
                final JsonNode data = record.get(column.getName());
Severity: Major
Found in src/main/java/org/embulk/input/zendesk/RecordImporter.java and 3 other locations - About 35 mins to fix
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 72..81
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 83..92
src/main/java/org/embulk/input/zendesk/RecordImporter.java on lines 94..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            case TOKEN:
                if (!task.getUsername().isPresent() || !task.getToken().isPresent()) {
                    throw new ConfigException(String.format("username and token are required for authentication method '%s'",
                        task.getAuthenticationMethod().name().toLowerCase()));
                }
Severity: Minor
Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java and 1 other location - About 35 mins to fix
src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java on lines 514..519

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method validateIncremental has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private void validateIncremental(PluginTask task)
    {
        if (task.getIncremental() && getZendeskService(task).isSupportIncremental()) {
            if (!task.getDedup()) {
                logger.warn("You've selected to skip de-duplicating records, result may contain duplicated data");
Severity: Minor
Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/main/java/org/embulk/input/zendesk/clients/ZendeskRestClient.java - About 30 mins to fix

    Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public TaskReport run(final TaskSource taskSource, final Schema schema, final int taskIndex, final PageOutput output)
    {
        final PluginTask task = TASK_MAPPER.map(taskSource, PluginTask.class);
    Severity: Minor
    Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method unifiedFieldNames has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private List<String> unifiedFieldNames(JsonNode jsonNode, String targetJsonName)
    {
        List<String> columnNames = new ArrayList<>();
        Iterator<JsonNode> records = ZendeskUtils.getListRecords(jsonNode, targetJsonName);
        while (records.hasNext()) {
    Severity: Minor
    Found in src/main/java/org/embulk/input/zendesk/ZendeskInputPlugin.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language