Sign upLogin

twitter/clockworkraven

View on GitHub
Star
app/controllers/evaluations_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method update_template has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  def update_template
    params[:evaluation] ||= {}

    if @evaluation.tasks.size > 0
      @fields = @evaluation.tasks.first.data.keys
Severity: Minor
Found in app/controllers/evaluations_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_template has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update_template
    params[:evaluation] ||= {}

    if @evaluation.tasks.size > 0
      @fields = @evaluation.tasks.first.data.keys
Severity: Minor
Found in app/controllers/evaluations_controller.rb - About 1 hr to fix

    Method create has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    if params[:based_on]
      @evaluation = Evaluation.based_on(Evaluation.find(params[:based_on]))
      @evaluation.attributes = params[:evaluation]
    else
    Severity: Minor
    Found in app/controllers/evaluations_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def update
    @evaluation.attributes = params[:evaluation]

    # parse data
    data = nil
    Severity: Minor
    Found in app/controllers/evaluations_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create
    if params[:based_on]
      @evaluation = Evaluation.based_on(Evaluation.find(params[:based_on]))
      @evaluation.attributes = params[:evaluation]
    else
    Severity: Minor
    Found in app/controllers/evaluations_controller.rb - About 1 hr to fix

      Method update has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def update
    @evaluation.attributes = params[:evaluation]

    # parse data
    data = nil
      Severity: Minor
      Found in app/controllers/evaluations_controller.rb - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if params[:evaluation][:data]
      begin
        data = InputParser.parse(params[:evaluation][:data])
      rescue InputParser::ParseError => e
        success = false
        Severity: Minor
        Found in app/controllers/evaluations_controller.rb and 1 other location - About 25 mins to fix
        app/controllers/evaluations_controller.rb on lines 138..144

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if params[:evaluation][:data]
      begin
        data = InputParser.parse(params[:evaluation][:data])
      rescue InputParser::ParseError => e
        success = false
        Severity: Minor
        Found in app/controllers/evaluations_controller.rb and 1 other location - About 25 mins to fix
        app/controllers/evaluations_controller.rb on lines 100..106

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status