Showing 66 of 66 total issues
Function _fnApplyCustomisation
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
"_fnApplyCustomisation": function ()
{
var oConfig = this.s.oInit;
if ( typeof oConfig.activate != 'undefined' )
Method sync_users
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
def sync_users
init_if_needed
# get rid of existing lists
MTurkUser.where('prod = 1 AND ((banned = 1) OR (trusted = 1))').each do |u|
Method fetch_results
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
def fetch_results task
hit_id = task.mturk_hit
return unless hit_id
assignments = mturk_run{mturk(task.evaluation).getAssignmentsForHIT :HITId => hit_id}
# return if we don't have a response from a MTurk user
Method update_template
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update_template
params[:evaluation] ||= {}
if @evaluation.tasks.size > 0
@fields = @evaluation.tasks.first.data.keys
Function show
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
, show: function () {
var $tip
, inside
, pos
, actualWidth
Method create
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def create
if params[:based_on]
@evaluation = Evaluation.based_on(Evaluation.find(params[:based_on]))
@evaluation.attributes = params[:evaluation]
else
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def update
@evaluation.attributes = params[:evaluation]
# parse data
data = nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _fnDomColumnButton
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
"_fnDomColumnButton": function ( i )
{
var
that = this,
oColumn = this.s.dt.aoColumns[i],
Method sync_users
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def sync_users
init_if_needed
# get rid of existing lists
MTurkUser.where('prod = 1 AND ((banned = 1) OR (trusted = 1))').each do |u|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method thread_pool
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def Threading.thread_pool items, size=16, retry_count=3, &processor
queue = Queue.new
items.each {|o| queue.push o}
threads = []
results = []
Function slide
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
, slide: function (type, next) {
var $active = this.$element.find('.active')
, $next = next || $active[type]()
, isCycling = this.interval
, direction = type == 'next' ? 'left' : 'right'
Method create
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
def create
if params[:based_on]
@evaluation = Evaluation.based_on(Evaluation.find(params[:based_on]))
@evaluation.attributes = params[:evaluation]
else
Function _handleData
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
_handleData: function(data) {
// update progress bar and text
$('#progress_bar').css('width', data.percentage + '%');
$('.completed').text(data.completed);
$('.total').text(data.total);
Method update
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update
@evaluation.attributes = params[:evaluation]
# parse data
data = nil
Function _fnAddButtons
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
"_fnAddButtons": function ()
{
var
nButton,
sExclude = ","+this.s.aiExclude.join(',')+",";
Method responses_csv
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def responses_csv(sep = ',')
CSV.generate(:col_sep => sep) do |csv|
# Pull out the fields that were uploaded with the original data,
# so that we can output these along with the task responses.
orig_fields_keys = if @task_responses.empty?
Function _handleData
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
_handleData: function(data) {
// update progress bar and text
$('#progress_bar').css('width', data.percentage + '%');
$('.completed').text(data.completed);
$('.total').text(data.total);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def update
current_user.name = params[:user][:name] unless params[:user][:name].nil?
current_user.email = params[:user][:email] unless params[:user][:email].nil?
unless params[:user][:password].blank?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function setupButtons
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
setupButtons: function(name, posSelector, negSelector, controlsSelector, spinnerSelector, positiveResponse) {
$(posSelector).add(negSelector).bind('ajax:before', function() {
// fade out the controls and fade in a spinner while we're loading
// the response
console.log(name, 'starting request');
Similar blocks of code found in 2 locations. Consider refactoring. Open
this.timeout = setTimeout(function() {
if (self.hoverState == 'out') self.hide()
}, self.options.delay.hide)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 55.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76