Sign upLogin

twitter/clockworkraven

View on GitHub
Star
lib/m_turk_utils.rb

Summary

Maintainability
D
1 day
Test Coverage

Method fetch_results has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def fetch_results task
      hit_id = task.mturk_hit
      return unless hit_id
      assignments = mturk_run{mturk(task.evaluation).getAssignmentsForHIT :HITId => hit_id}
      # return if we don't have a response from a MTurk user
Severity: Minor
Found in lib/m_turk_utils.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File m_turk_utils.rb has 328 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module MTurkUtils
  # Basic structure of the XML structure for an HTML question.
  HTML_QUESTION_XML = <<-END_XML
    <HTMLQuestion xmlns="http://mechanicalturk.amazonaws.com/AWSMechanicalTurkDataSchemas/2011-11-11/HTMLQuestion.xsd">
      <HTMLContent><![CDATA[
Severity: Minor
Found in lib/m_turk_utils.rb - About 3 hrs to fix

    Method sync_users has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def sync_users
      init_if_needed

      # get rid of existing lists
      MTurkUser.where('prod = 1 AND ((banned = 1) OR (trusted = 1))').each do |u|
    Severity: Minor
    Found in lib/m_turk_utils.rb - About 1 hr to fix

      Method fetch_results has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def fetch_results task
      hit_id = task.mturk_hit
      return unless hit_id
      assignments = mturk_run{mturk(task.evaluation).getAssignmentsForHIT :HITId => hit_id}
      # return if we don't have a response from a MTurk user
      Severity: Minor
      Found in lib/m_turk_utils.rb - About 1 hr to fix

        Method sync_users has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def sync_users
      init_if_needed

      # get rid of existing lists
      MTurkUser.where('prod = 1 AND ((banned = 1) OR (trusted = 1))').each do |u|
        Severity: Minor
        Found in lib/m_turk_utils.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method mturk_run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def mturk_run &block
      init_if_needed
      retries = 0

      begin
        Severity: Minor
        Found in lib/m_turk_utils.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method force_expire has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def force_expire task
      hit_id = task.mturk_hit
      return unless hit_id

      begin
        Severity: Minor
        Found in lib/m_turk_utils.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if page[:WorkerBlock].kind_of? Array
          banned += page[:WorkerBlock].map{|h| h[:WorkerId]}
        else
          banned.push page[:WorkerBlock][:WorkerId]
        Severity: Minor
        Found in lib/m_turk_utils.rb and 1 other location - About 15 mins to fix
        lib/m_turk_utils.rb on lines 410..413

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if page[:Qualification].kind_of? Array
          trusted += page[:Qualification].map{|h| h[:SubjectId]}
        else
          trusted.push page[:Qualification][:SubjectId]
        Severity: Minor
        Found in lib/m_turk_utils.rb and 1 other location - About 15 mins to fix
        lib/m_turk_utils.rb on lines 440..443

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status