Sign upLogin

ucberkeley/moocchat

View on GitHub
Star

Showing 132 of 132 total issues

Method getValues has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public static <T> T[] getValues(Class<T> wsdlEnumClass) {
        List<T> values = new ArrayList<T>();
        for (Field field : wsdlEnumClass.getFields()) {
            if (Modifier.isPublic(field.getModifiers()) &&
                Modifier.isFinal(field.getModifiers()) &&
Severity: Minor
Found in turk/src/com/amazonaws/mturk/util/WsdlEnumUtil.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method runCommand has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  protected void runCommand(CommandLine cmdLine) throws Exception {

      if (!cmdLine.hasOption(ARG_QUALTYPE) &&
          !cmdLine.hasOption(ARG_INPUT_FILE)) {
          log.error("Either -" + ARG_QUALTYPE + " or -" + ARG_INPUT_FILE + " should be passed");
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method runCommand has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  protected void runCommand(CommandLine cmdLine) throws Exception {
    if (!cmdLine.hasOption(ARG_WORKERID)) {

      log.fatal("Missing: -" + ARG_WORKERID + " [worker to grant bonus to]");
      System.exit(-1);
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/GrantBonus.java - About 1 hr to fix

    Method ensure_setup_socket_for has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def ensure_setup_socket_for(env)
    channel, my_position, my_id = channel_and_position_from_url(env['ORIGINAL_FULLPATH'])
    unless @groups.has_key?(channel) && @groups[channel][my_position]
      ws = Faye::WebSocket.new(env, nil, {ping: KEEPALIVE_TIME })
      @groups[channel] ||= []
    Severity: Minor
    Found in app/middleware/chat_server.rb - About 1 hr to fix

      Method grantQualRequestsInFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public void grantQualRequestsInFile(String fileName, Integer defaultValue) throws IOException {
    if (fileName == null) {
      throw new IllegalArgumentException("fileName must not be null");
    }
      Severity: Minor
      Found in turk/src/com/amazonaws/mturk/cmd/GrantQualificationRequests.java - About 1 hr to fix

        Method redistribute_message has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def redistribute_message(websocket_data, channel, my_position)
    message = extract_text(websocket_data)
    type = extract_type(websocket_data)
    taskid = extract_taskid(websocket_data)
    if type != "heartbeat"   # Heartbeat too spammy
        Severity: Minor
        Found in app/middleware/chat_server.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      for (String hitId : hitWebsiteURLs.keySet()) {
                List<String> fields = new ArrayList<String>();
                fields.add(hitId);
                fields.add(hitWebsiteURLs.get(hitId));
                fields.add("Is inappropriate:");
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/summary/SiteFilterResultsSummarizer.java and 1 other location - About 1 hr to fix
          turk/src/com/amazonaws/mturk/cmd/summary/ImageCategoryResultsSummarizer.java on lines 90..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for(String hitId : hitImageFilenames.keySet()){
            List<String> fields = new ArrayList<String>();
            fields.add(hitId);
            fields.add(hitImageFilenames.get(hitId));
            fields.add("Category:");
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/summary/ImageCategoryResultsSummarizer.java and 1 other location - About 1 hr to fix
          turk/src/com/amazonaws/mturk/cmd/summary/SiteFilterResultsSummarizer.java on lines 86..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method loadHITs has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            public HIT[] loadHITs(String input, String question, String props, 
      String previewFile, int maxHITs, boolean preview, String outputFile, boolean append) throws Exception {
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 1 hr to fix

            Method initService has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              protected void initService() {
    if (service == null) {
      
      if (ClientConfig.SANDBOX_SERVICE_URL.equalsIgnoreCase(config.getServiceURL())) {
        // configure sandbox/throttling friendly settings
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/cmd/AbstractCmd.java - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method close has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              public synchronized void close() {
    realWriter.close();
    // check if headers were dynamically modified
    if (outputFilename != null && this.getFieldNamesSize() != this.realWriter.getFieldNamesSize()) {
      try {
            Severity: Minor
            Found in turk/src/com/amazonaws/mturk/util/HITResultProcessor.java - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function update has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            function update() {
    $.ajax({
        url:'https://moocchat.herokuapp.com/get_current_timestamp_utc/',
        dataType: 'jsonp',
        type: 'GET',
            Severity: Minor
            Found in public/moocchat_global_notification.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function receiveMessages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              receiveMessages: function() {
    var self = this;
    this.ws.onmessage = function(message) {
      var data = JSON.parse(message.data)
      if (data.type == "message" & self.isBoth()) {
            Severity: Minor
            Found in app/assets/javascripts/web_socket.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method makeTemplate has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              private void makeTemplate(String template, String target, String type, String os,
      String templateRootDirPath, String targetRootDirPath, String scriptTemplateDir) throws Exception {
            Severity: Major
            Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 50 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      case Hit:
          copyTemplateFile(templateFileRoot, targetFileName, ".input");
          
          // generate the scripts for HIT operations
          generateScript(scriptTemplateDir, target, targetDirPath, "run", scriptType);
              Severity: Minor
              Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java and 1 other location - About 50 mins to fix
              turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java on lines 187..193

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  for(int i=0; i<templTypes.length; i++) {
      TemplateType type = templTypes[i];
      
      if (i > 0)
        templTypesStr.append(", ");
              Severity: Minor
              Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java and 1 other location - About 50 mins to fix
              turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java on lines 79..86

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  for(int i=0; i<scriptTypes.length; i++) {
      CreateScriptUtil.ScriptType type = scriptTypes[i];
      
      if (i > 0)
        scriptTypesStr.append(", ");
              Severity: Minor
              Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java and 1 other location - About 50 mins to fix
              turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java on lines 68..75

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      case Qual:
          copyTemplateFile(templateFileRoot, targetFileName, ".answer");
          
          // generate the scripts for Qual operations
          generateScript(scriptTemplateDir, target, targetDirPath, "createQualification", scriptType);
              Severity: Minor
              Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java and 1 other location - About 50 mins to fix
              turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java on lines 180..186

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                    if (!cmdLine.hasOption(ARG_QUALTYPE) &&
          !cmdLine.hasOption(ARG_INPUT_FILE)) {
        log.error("Either -" + ARG_QUALTYPE + " or -" + ARG_INPUT_FILE + " must be passed");
        System.exit(-1);
              Severity: Major
              Found in turk/src/com/amazonaws/mturk/cmd/AssignQualification.java and 2 other locations - About 45 mins to fix
              turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java on lines 58..63
              turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java on lines 71..75

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                    if (!cmdLine.hasOption(ARG_QUALTYPE) &&
          !cmdLine.hasOption(ARG_INPUT_FILE)) {
          log.error("Either -" + ARG_QUALTYPE + " or -" + ARG_INPUT_FILE + " should be passed");
        System.exit(-1);
      }
              Severity: Major
              Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java and 2 other locations - About 45 mins to fix
              turk/src/com/amazonaws/mturk/cmd/AssignQualification.java on lines 65..70
              turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java on lines 58..63

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language