ucberkeley/moocchat

View on GitHub
turk/src/com/amazonaws/mturk/cmd/ApproveWork.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method approveAssignmentsInFile has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  public void approveAssignmentsInFile(String fileName) throws IOException {
    if (fileName == null) {
      throw new IllegalArgumentException("fileName must not be null");
    }
    
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/ApproveWork.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method approveAssignmentsInFile has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public void approveAssignmentsInFile(String fileName) throws IOException {
    if (fileName == null) {
      throw new IllegalArgumentException("fileName must not be null");
    }
    
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/ApproveWork.java - About 1 hr to fix

    Method approveHitsInFile has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      public void approveHitsInFile(String fileName) throws IOException {
        if (fileName == null) {
          throw new IllegalArgumentException("fileName must not be null");
        }
        
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/ApproveWork.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method runCommand has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      protected void runCommand(CommandLine cmdLine) throws Exception {
        if (!cmdLine.hasOption(ARG_ASSIGNMENT) && !cmdLine.hasOption(ARG_APPROVEFILE) && !cmdLine.hasOption(ARG_SUCCESSFILE)) {
    
          log.error("Missing: you must supply one of -" + ARG_ASSIGNMENT 
              + " or -" + ARG_APPROVEFILE + " or -" + ARG_SUCCESSFILE);
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/ApproveWork.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status