Sign upLogin

ucberkeley/moocchat

View on GitHub
Star
turk/src/com/amazonaws/mturk/cmd/AssignQualification.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method runCommand has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    protected void runCommand(CommandLine cmdLine) throws Exception {
      if (!cmdLine.hasOption(ARG_QUALTYPE) &&
          !cmdLine.hasOption(ARG_INPUT_FILE)) {
        log.error("Either -" + ARG_QUALTYPE + " or -" + ARG_INPUT_FILE + " must be passed");
        System.exit(-1);
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/AssignQualification.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method runCommand has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected void runCommand(CommandLine cmdLine) throws Exception {
      if (!cmdLine.hasOption(ARG_QUALTYPE) &&
          !cmdLine.hasOption(ARG_INPUT_FILE)) {
        log.error("Either -" + ARG_QUALTYPE + " or -" + ARG_INPUT_FILE + " must be passed");
        System.exit(-1);
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/AssignQualification.java - About 1 hr to fix

    Method assignQualification has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public void assignQualification( String[] qualIds, String workerId, String score, Boolean notify ) {
        Integer value = null;
        if (score != null) {
            try {
                // Verify that strValue is an integer and not something else
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/AssignQualification.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          if (!cmdLine.hasOption(ARG_QUALTYPE) &&
          !cmdLine.hasOption(ARG_INPUT_FILE)) {
        log.error("Either -" + ARG_QUALTYPE + " or -" + ARG_INPUT_FILE + " must be passed");
        System.exit(-1);
    Severity: Major
    Found in turk/src/com/amazonaws/mturk/cmd/AssignQualification.java and 2 other locations - About 45 mins to fix
    turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java on lines 58..63
    turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java on lines 71..75

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          log.info(AssignQualification.class.getName() + 
          " -" + ARG_INPUT_FILE + " [ input file containing Qualification Type] " +
          " -" + ARG_SCORE_FILE + " [ score file ] " + 
          " -" + ARG_SCORE + " [value to grant]");
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/AssignQualification.java and 1 other location - About 35 mins to fix
    turk/src/com/amazonaws/mturk/cmd/AssignQualification.java on lines 49..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          log.info(AssignQualification.class.getName() + 
          " -" + ARG_QUALTYPE + " [qual to grant] " + 
          " -" + ARG_WORKERID + " [worker to be granted]" + 
          " -" + ARG_SCORE + " [value to grant]");
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/AssignQualification.java and 1 other location - About 35 mins to fix
    turk/src/com/amazonaws/mturk/cmd/AssignQualification.java on lines 54..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status