Sign upLogin

ucberkeley/moocchat

View on GitHub
Star
turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java

Summary

Maintainability
C
1 day
Test Coverage

Method createQualificationType has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public boolean createQualificationType(String qualFile, String answerFile,
      String propertiesFile, boolean noRetry) {
    String test = null;
    String answerKey = null;
    Properties props = new Properties();
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java - About 3 hrs to fix

    Method createQualificationType has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      public boolean createQualificationType(String qualFile, String answerFile,
      String propertiesFile, boolean noRetry) {
    String test = null;
    String answerKey = null;
    Properties props = new Properties();
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return false;
    Severity: Major
    Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return false;
      Severity: Major
      Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return false;
        Severity: Major
        Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java - About 30 mins to fix

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

            protected void initOptions() {
    opt.addOption(ARG_QUESTION, true, 
      "(optional) Path to the file containing the question");
    opt.addOption(ARG_PROPERTIES, true, 
      "(required) Path to the file containing the properties for the qualification");
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java and 4 other locations - About 40 mins to fix
          turk/src/com/amazonaws/mturk/cmd/DeleteHITs.java on lines 43..52
          turk/src/com/amazonaws/mturk/cmd/GetResults.java on lines 71..80
          turk/src/com/amazonaws/mturk/cmd/GrantBonus.java on lines 33..42
          turk/src/com/amazonaws/mturk/cmd/UpdateQualificationScore.java on lines 37..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

            protected void printHelp() {
    formatter.printHelp(CreateQualificationType.class.getName() 
        + " -" + ARG_QUESTION + " [path to question file] "
        + " -" + ARG_PROPERTIES + " [path to properties file] "
        + "(-" + ARG_ANSWER + " [path to answer file])",
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java and 4 other locations - About 40 mins to fix
          turk/src/com/amazonaws/mturk/cmd/ExtendHITs.java on lines 51..57
          turk/src/com/amazonaws/mturk/cmd/LoadHITs.java on lines 75..80
          turk/src/com/amazonaws/mturk/cmd/RevokeQualification.java on lines 38..43
          turk/src/com/amazonaws/mturk/cmd/UpdateQualificationScore.java on lines 44..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status