Sign upLogin

ucberkeley/moocchat

View on GitHub
Star
turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java

Summary

Maintainability
C
1 day
Test Coverage

Method evaluateQualificationRequests has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

  private void evaluateQualificationRequests(String qualid, String answerFile,
      boolean preview) {
    
    if (preview) {
        log.info("Preview flag is set. Qualification requests will not be approved or rejected.");
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method evaluateQualificationRequests has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private void evaluateQualificationRequests(String qualid, String answerFile,
      boolean preview) {
    
    if (preview) {
        log.info("Preview flag is set. Qualification requests will not be approved or rejected.");
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java - About 3 hrs to fix

    Method runCommand has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      protected void runCommand(CommandLine cmdLine) throws Exception {
    if (!cmdLine.hasOption(QUAL_TYPE) &&
        !cmdLine.hasOption(INPUT_FILE)) {

      log.error("Either -" + QUAL_TYPE + " or -" + INPUT_FILE + " should be passed");
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method runCommand has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      protected void runCommand(CommandLine cmdLine) throws Exception {
    if (!cmdLine.hasOption(QUAL_TYPE) &&
        !cmdLine.hasOption(INPUT_FILE)) {

      log.error("Either -" + QUAL_TYPE + " or -" + INPUT_FILE + " should be passed");
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/EvaluateQualificationRequests.java - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status