Sign upLogin

ucberkeley/moocchat

View on GitHub
Star
turk/src/com/amazonaws/mturk/cmd/LoadHITs.java

Summary

Maintainability
D
1 day
Test Coverage

Method loadHITs has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  public HIT[] loadHITs(String input, String question, String props, 
      String previewFile, int maxHITs, boolean preview, String outputFile, boolean append) throws Exception {

    HITDataInput hi = new HITDataCSVReader(input);
    HITProperties hc = new HITProperties(props);
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadHITs has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public HIT[] loadHITs(String input, String question, String props, 
      String previewFile, int maxHITs, boolean preview, String outputFile, boolean append) throws Exception {

    HITDataInput hi = new HITDataCSVReader(input);
    HITProperties hc = new HITProperties(props);
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 2 hrs to fix

    Method runCommand has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      protected void runCommand(CommandLine cmdLine) throws Exception {
    if (!cmdLine.hasOption(ARG_INPUT)) {

      log.error("Missing: -" + ARG_INPUT 
          + " [path to input file -- ie. c:\\mturk\\helloworld.input]");
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 1 hr to fix

      Method runCommand has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        protected void runCommand(CommandLine cmdLine) throws Exception {
    if (!cmdLine.hasOption(ARG_INPUT)) {

      log.error("Missing: -" + ARG_INPUT 
          + " [path to input file -- ie. c:\\mturk\\helloworld.input]");
      Severity: Minor
      Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method loadHITs has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        public HIT[] loadHITs(String input, String question, String props, 
      String previewFile, int maxHITs, boolean preview, String outputFile, boolean append) throws Exception {
      Severity: Major
      Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 1 hr to fix

        Method loadHITs has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          public HIT[] loadHITs(String input, String question, String props, 
      String previewFile, int maxHITs, boolean preview) throws Exception {
        Severity: Minor
        Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            protected void initOptions() {
    opt.addOption(ARG_INPUT, true,
        "(required) The input file to use (in comma-delimited format, ie. helloworld.input)");
    opt.addOption(ARG_QUESTION, true,
        "(required) The question file to use (ie. helloworld.question)");
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java and 1 other location - About 1 hr to fix
          turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java on lines 48..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

            protected void printHelp() {
    formatter.printHelp(LoadHITs.class.getName()
        + " -" + ARG_INPUT + " [input_file]"
        + " -" + ARG_QUESTION + " [question_file]"
        + " -" + ARG_PROPERTIES + " [properties_file]", opt);
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/LoadHITs.java and 4 other locations - About 40 mins to fix
          turk/src/com/amazonaws/mturk/cmd/CreateQualificationType.java on lines 60..66
          turk/src/com/amazonaws/mturk/cmd/ExtendHITs.java on lines 51..57
          turk/src/com/amazonaws/mturk/cmd/RevokeQualification.java on lines 38..43
          turk/src/com/amazonaws/mturk/cmd/UpdateQualificationScore.java on lines 44..49

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status