Sign upLogin

ucberkeley/moocchat

View on GitHub
Star
turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java

Summary

Maintainability
C
1 day
Test Coverage

Method runCommand has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  protected void runCommand(CommandLine cmdLine) throws Exception {

    if (!cmdLine.hasOption(ARG_TEMPLATE)) {
      log.error("Missing: -" + ARG_TEMPLATE);
      printHelp();
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 1 hr to fix

    Method makeTemplate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private void makeTemplate(String template, String target, String type, String os,
      String templateRootDirPath, String targetRootDirPath, String scriptTemplateDir) throws Exception {

    String targetDirPath = targetRootDirPath + File.separator + target;
    File targetDir = new File(targetDirPath);
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 1 hr to fix

      Method makeTemplate has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        private void makeTemplate(String template, String target, String type, String os,
      String templateRootDirPath, String targetRootDirPath, String scriptTemplateDir) throws Exception {
      Severity: Major
      Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 50 mins to fix

        Method makeTemplate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          private void makeTemplate(String template, String target, String type, String os,
      String templateRootDirPath, String targetRootDirPath, String scriptTemplateDir) throws Exception {

    String targetDirPath = targetRootDirPath + File.separator + target;
    File targetDir = new File(targetDirPath);
        Severity: Minor
        Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method runCommand has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          protected void runCommand(CommandLine cmdLine) throws Exception {

    if (!cmdLine.hasOption(ARG_TEMPLATE)) {
      log.error("Missing: -" + ARG_TEMPLATE);
      printHelp();
        Severity: Minor
        Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method generateScript has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          private static void generateScript(String scriptTemplateDir, String target, 
      String targetDirPath, String command, CreateScriptUtil.ScriptType type) throws Exception {
        Severity: Minor
        Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 35 mins to fix

          Method copyTemplateFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            private void copyTemplateFile(String sourceRoot, String targetRoot, String extension) throws Exception {
    String inputFileName = sourceRoot + extension;
    String outputFileName = targetRoot + extension;
    
    System.out.println("Copying resource file: " + outputFileName);
          Severity: Minor
          Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method printHelp has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            protected void printHelp() {   
    StringBuffer templTypesStr = new StringBuffer("");
    TemplateType[] templTypes = TemplateType.values();
    for(int i=0; i<templTypes.length; i++) {
      TemplateType type = templTypes[i];
          Severity: Minor
          Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            protected void initOptions() {
    opt.addOption(ARG_TEMPLATE, true,
    "(required) The name of one of the sample directories (eg. helloworld).");
    opt.addOption(ARG_TARGET, true,
    "(required) The name of the target directory (eg. new_application)");
          Severity: Major
          Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java and 1 other location - About 1 hr to fix
          turk/src/com/amazonaws/mturk/cmd/LoadHITs.java on lines 58..73

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  case Hit:
          copyTemplateFile(templateFileRoot, targetFileName, ".input");
          
          // generate the scripts for HIT operations
          generateScript(scriptTemplateDir, target, targetDirPath, "run", scriptType);
          Severity: Minor
          Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java and 1 other location - About 50 mins to fix
          turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java on lines 187..193

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              for(int i=0; i<templTypes.length; i++) {
      TemplateType type = templTypes[i];
      
      if (i > 0)
        templTypesStr.append(", ");
          Severity: Minor
          Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java and 1 other location - About 50 mins to fix
          turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java on lines 79..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              for(int i=0; i<scriptTypes.length; i++) {
      CreateScriptUtil.ScriptType type = scriptTypes[i];
      
      if (i > 0)
        scriptTypesStr.append(", ");
          Severity: Minor
          Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java and 1 other location - About 50 mins to fix
          turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java on lines 68..75

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  case Qual:
          copyTemplateFile(templateFileRoot, targetFileName, ".answer");
          
          // generate the scripts for Qual operations
          generateScript(scriptTemplateDir, target, targetDirPath, "createQualification", scriptType);
          Severity: Minor
          Found in turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java and 1 other location - About 50 mins to fix
          turk/src/com/amazonaws/mturk/cmd/MakeTemplate.java on lines 180..186

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status