Sign upLogin

ucberkeley/moocchat

View on GitHub
Star
turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method rejectQualRequests has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  private void rejectQualRequests(String[] qualReqs, String[] comments) {
    
    // If we're not given anything, just no-op
    if (qualReqs == null) {
      return;
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for (int i = 0; qualReqs != null && i < qualReqs.length; i++) {
      try {
        if (comments != null)
          comment = comments[i];
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java and 1 other location - About 2 hrs to fix
turk/src/com/amazonaws/mturk/cmd/GrantQualificationRequests.java on lines 141..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if (!cmdLine.hasOption(ARG_QUALREQ) && !cmdLine.hasOption(ARG_REJECTFILE)) {

      log.error("Missing: you must supply one of -" + ARG_QUALREQ + " or -" + ARG_REJECTFILE + ".");
      System.exit(-1);
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java and 2 other locations - About 45 mins to fix
turk/src/com/amazonaws/mturk/cmd/AssignQualification.java on lines 65..70
turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java on lines 71..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  protected void initOptions() {
    opt.addOption(ARG_QUALREQ, true,
        "The ID of the qualification request to reject (separate multiple qualification request IDs with a comma)");
    opt.addOption(ARG_REJECTFILE, true,
        "The name of the file that contains the qualification request IDs to be rejected (the columns must be titled "
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java and 1 other location - About 45 mins to fix
turk/src/com/amazonaws/mturk/cmd/RejectWork.java on lines 44..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public void rejectQualRequestsInFile(String fileName) throws IOException {
    if (fileName == null) {
      throw new IllegalArgumentException();
    }
Severity: Minor
Found in turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java and 1 other location - About 45 mins to fix
turk/src/com/amazonaws/mturk/cmd/RejectWork.java on lines 84..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status