Sign upLogin

ucberkeley/moocchat

View on GitHub
Star
turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java

Summary

Maintainability
C
1 day
Test Coverage

Method updateQualificationType has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public void updateQualificationType( String qualTypeId, String statusString,
      String questionFile, String answerFile, 
      String propertiesFile ) throws Exception
  {
    String test = null;
Severity: Major
Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java - About 2 hrs to fix

    Method updateQualificationType has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      public void updateQualificationType( String qualTypeId, String statusString,
      String questionFile, String answerFile, 
      String propertiesFile ) throws Exception
  {
    String test = null;
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method runCommand has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      protected void runCommand(CommandLine cmdLine) throws Exception {

      if (!cmdLine.hasOption(ARG_QUALTYPE) &&
          !cmdLine.hasOption(ARG_INPUT_FILE)) {
          log.error("Either -" + ARG_QUALTYPE + " or -" + ARG_INPUT_FILE + " should be passed");
    Severity: Minor
    Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java - About 1 hr to fix

      Method runCommand has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        protected void runCommand(CommandLine cmdLine) throws Exception {

      if (!cmdLine.hasOption(ARG_QUALTYPE) &&
          !cmdLine.hasOption(ARG_INPUT_FILE)) {
          log.error("Either -" + ARG_QUALTYPE + " or -" + ARG_INPUT_FILE + " should be passed");
      Severity: Minor
      Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updateQualificationType has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        public void updateQualificationType( String qualTypeId, String statusString,
      String questionFile, String answerFile, 
      String propertiesFile ) throws Exception
      Severity: Minor
      Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              if (!cmdLine.hasOption(ARG_QUALTYPE) &&
          !cmdLine.hasOption(ARG_INPUT_FILE)) {
          log.error("Either -" + ARG_QUALTYPE + " or -" + ARG_INPUT_FILE + " should be passed");
        System.exit(-1);
      }
        Severity: Major
        Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java and 2 other locations - About 45 mins to fix
        turk/src/com/amazonaws/mturk/cmd/AssignQualification.java on lines 65..70
        turk/src/com/amazonaws/mturk/cmd/RejectQualificationRequests.java on lines 58..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            formatter.printHelp(UpdateQualificationType.class.getName() +
        " -" + ARG_QUALTYPE + " [QualTypeId] " +
        "(-" + ARG_STATUS + " [Active|Inactive]) " +
        "(-" + ARG_QUESTION + " [path to question file]) " +
        "(-" + ARG_PROPERTIES + " [path to properties file]) " +
        Severity: Minor
        Found in turk/src/com/amazonaws/mturk/cmd/UpdateQualificationType.java and 1 other location - About 40 mins to fix
        turk/src/com/amazonaws/mturk/cmd/GrantBonus.java on lines 45..49

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status