Sign upLogin

ulmic/tramway-dev

View on GitHub
Star
tramway-api/app/controllers/tramway/api/v1/application_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method record has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def record
          if params[:key].present?
            if Tramway::Api.other_id_methods_of(model: model_class).include? params[:key].to_sym
              @record = model_class.find_by! params[:key] => params[:id] if params[:id].present?
            end
Severity: Minor
Found in tramway-api/app/controllers/tramway/api/v1/application_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_action has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def check_action
          action_is_available = checking_roles.map do |role|
            Tramway::Api.action_is_available(
              action: action_name.to_sym,
              project: (@application_engine || application_name),
Severity: Minor
Found in tramway-api/app/controllers/tramway/api/v1/application_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_available_model_class has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def check_available_model_class
          unless model_class
            head(:unauthorized) && return unless current_tramway_user

            head(:unprocessable_entity) && return
Severity: Minor
Found in tramway-api/app/controllers/tramway/api/v1/application_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status