Sign upLogin

ulmic/tramway-dev

View on GitHub
Star
tramway-api/lib/tramway/api.rb

Summary

Maintainability
A
45 mins
Test Coverage

Method action_is_available has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def action_is_available(project:, role: :open, model_name:, action:, current_user: nil)
        actions = select_actions(project: project, role: role, model_name: model_name)
        if actions.present? && !actions.is_a?(Array)
          raise "Looks like you did not used array type to define action permissions. Remember it should be this way: `#{model_name} => [ :#{action} ]` or `#{model_name} => [ { #{action}: lambda { |record, current_user| your_condition } } ]`"
        end
Severity: Minor
Found in tramway-api/lib/tramway/api.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status