Sign upLogin

unclesp1d3r/CipherSwarm

View on GitHub
Star
app/controllers/api/v1/client/agents_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage
B
81%

Method submit_error has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def submit_error
    if @agent.blank?
      render json: { error: "Agent not found" }, status: :not_found
      return
    end
Severity: Minor
Found in app/controllers/api/v1/client/agents_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method submit_error has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def submit_error
    if @agent.blank?
      render json: { error: "Agent not found" }, status: :not_found
      return
    end
Severity: Minor
Found in app/controllers/api/v1/client/agents_controller.rb - About 1 hr to fix

Method submit_benchmark has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def submit_benchmark
    # There's a weird bug where the JSON is sometimes in the body and as a param.
    if params[:hashcat_benchmarks].nil?
      render json: { error: "No benchmarks submitted" }, status: :bad_request
      return
Severity: Minor
Found in app/controllers/api/v1/client/agents_controller.rb - About 1 hr to fix

Method submit_benchmark has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def submit_benchmark
    # There's a weird bug where the JSON is sometimes in the body and as a param.
    if params[:hashcat_benchmarks].nil?
      render json: { error: "No benchmarks submitted" }, status: :bad_request
      return
Severity: Minor
Found in app/controllers/api/v1/client/agents_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status