Sign upLogin

unclesp1d3r/CipherSwarm

View on GitHub
Star
app/controllers/api/v1/client/tasks_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage
C
76%

Method submit_status has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def submit_status
    @task = @agent.tasks.find(params[:id])
    @task.update(activity_timestamp: Time.zone.now)
    status = @task.hashcat_statuses.build({
                                            original_line: params[:original_line],
Severity: Major
Found in app/controllers/api/v1/client/tasks_controller.rb - About 2 hrs to fix

Method submit_status has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def submit_status
    @task = @agent.tasks.find(params[:id])
    @task.update(activity_timestamp: Time.zone.now)
    status = @task.hashcat_statuses.build({
                                            original_line: params[:original_line],
Severity: Minor
Found in app/controllers/api/v1/client/tasks_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method submit_crack has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def submit_crack
    timestamp = params[:timestamp]
    hash = params[:hash]
    plain_text = params[:plain_text]
Severity: Minor
Found in app/controllers/api/v1/client/tasks_controller.rb - About 1 hr to fix

Method submit_crack has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def submit_crack
    timestamp = params[:timestamp]
    hash = params[:hash]
    plain_text = params[:plain_text]
Severity: Minor
Found in app/controllers/api/v1/client/tasks_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return head :gone if @task.paused?
Severity: Major
Found in app/controllers/api/v1/client/tasks_controller.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return head :no_content
Severity: Major
Found in app/controllers/api/v1/client/tasks_controller.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

    return unless task.completed?
Severity: Major
Found in app/controllers/api/v1/client/tasks_controller.rb - About 30 mins to fix

There are no issues that match your filters.

Category
Status