Sign upLogin

unclesp1d3r/CipherSwarm

View on GitHub
Star
app/models/agent.rb
7bcdfe05

Summary

Maintainability
A
3 hrs
Test Coverage
B
81%

Method new_task has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def new_task
    # Immediately return the first incomplete task if there's no fatal errors for it.
    incomplete_task = tasks.incomplete.find do |task|
      !agent_errors.exists?(severity: :fatal, task_id: task.id) && task.uncracked_remaining
    end
Severity: Minor
Found in app/models/agent.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method new_task has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def new_task
    # Immediately return the first incomplete task if there's no fatal errors for it.
    incomplete_task = tasks.incomplete.find do |task|
      !agent_errors.exists?(severity: :fatal, task_id: task.id) && task.uncracked_remaining
    end
Severity: Minor
Found in app/models/agent.rb - About 1 hr to fix

Avoid too many return statements within this method.
Open

        return tasks.create(attack: attack, start_date: Time.zone.now)
Severity: Major
Found in app/models/agent.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return pending_task if pending_task
Severity: Major
Found in app/models/agent.rb - About 30 mins to fix

There are no issues that match your filters.

Category
Status