unicef/magicbox-open-api

Function `value_map` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    let value_map = shapefile.reduce((ary, element) => {
      let tempList = Object.keys(element).filter(key => {
        return (key.startsWith('id_'))
      }).map(key => {
        return element[key]

Found in api/helpers/general.js - About 1 hr to fix

Function `countries_with_this_kind_data` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export const countries_with_this_kind_data = (kind, source, country) => {
  return new Promise((resolve, reject) => {
    // Get country name for each shapefile
    getShapeFiles(kind, source)
      .then(shapefileSet => {

Found in api/helpers/general.js - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading