Showing 72 of 96 total issues
File utils.js
has 252 lines of code (exceeds 250 allowed). Consider refactoring. Open
import moment from 'moment'
import { scoreTypes } from '../../models/Score/schema'
import User from '../../models/User'
import BotController from '../BotController'
Function generateUserScoresMessage
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
async generateUserScoresMessage(user) {
const response = { msg: '', attachments: [] }
if (user.isCoreTeam) {
const { score } = await RankingController.getMonthlyPositionByUser(
Function handleExternalInteraction
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
async handleExternalInteraction(payload) {
try {
const { scoreType, achievementType, queries, details } = payload
const user = await User.findOne(queries.user)
Function handleUserPartner
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
async handleUserPartner(user) {
try {
if (Object.keys(partnerLevels).includes(user.referrer.identification)) {
const partnerLevelAlreadyGiven = await LevelHistory.findOne({
user: user.uuid,
Function handle
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
async handle({ user, achievementType, provider = 'Atena' }) {
try {
const achievementRanges = getAchievementValues(achievementType)
const [currentAchievement] = user.achievements.filter(
({ name }) => name === achievementType
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (reactionsSaved.length > reactions.length) {
const reactionsRemoved = this.findReactions({
mostReactions: reactionsSaved,
lessReactions: reactions
})
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 67.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (reactionsSaved.length < reactions.length) {
const reactionsAdded = this.findReactions({
mostReactions: reactions,
lessReactions: reactionsSaved
})
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 67.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function updateUserScore
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
async updateUserScore({ user, scoreEarned }) {
const score = {
value: user.score.value + scoreEarned,
lastUpdate: moment()
}
Function getCommandsText
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
getCommandsText({ isCoreTeam }) {
const message = {
msg: '*Confira a nossa lista de comandos:*',
attachments: [
{
Function clickOnProduct
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const clickOnProduct = name => {
const medals = [
{
name: 'iron',
displayMedal: 'Ferro',
Function createGeneralRanking
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
async createGeneralRanking() {
try {
const limit = 10000
let skip = 0
let position = 1
Function handleAchievementChange
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
async handleAchievementChange({
user,
score,
provider,
newAchievement,
Function participatedToMeetup
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const participatedToMeetup = () => {
const medals = [
{
name: 'iron',
displayMedal: 'Ferro',
Function reactionSended
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const reactionSended = () => {
const medals = [
{
name: 'iron',
displayMedal: 'Ferro',
Function scoreReactionReceived
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
async scoreReactionReceived({
receiver,
reaction,
payload,
alreadyAchieved
Function reactionReceived
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const reactionReceived = () => {
const medals = [
{
name: 'iron',
displayMedal: 'Ferro',
Function messageSended
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const messageSended = () => {
const medals = [
{
name: 'iron',
displayMedal: 'Ferro',
Function subscribedToMeetup
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const subscribedToMeetup = () => {
const medals = [
{
name: 'iron',
displayMedal: 'Ferro',
Function newslettersRead
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const newslettersRead = () => {
const medals = [
{
name: 'iron',
displayMedal: 'Ferro',
Function handle
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
async handle({ user, previousLevel }) {
try {
LevelHistory.create({
user: user.uuid,
level: {