Sign upLogin

unix1/spoof

View on GitHub
Star

Showing 106 of 106 total issues

Missing class import via use statement (line '37', column '33').
Open

        $this->connection = new \PDO(
Severity: Minor
Found in src/lib360/db/connection/PDO.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '49', column '23').
Open

            throw new \InvalidArgumentException("Connection by the name $name already exists.");
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method removeByName has a boolean flag argument $disconnect, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function removeByName($name, $disconnect = true)
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '194', column '23').
Open

            throw new \InvalidArgumentException(
Severity: Minor
Found in src/lib360/db/language/SQL.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '42', column '20').
Open

        $xml = new \DOMDocument('1.0', 'utf-8');
Severity: Minor
Found in src/lib360/db/data/RecordList.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getByName has a boolean flag argument $connect, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function getByName($name, $connect = true);
Severity: Minor
Found in src/lib360/db/connection/IPool.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '205', column '20').
Open

        $xml = new \DOMDocument('1.0', 'utf-8');
Severity: Minor
Found in src/lib360/db/data/Record.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '230', column '27').
Open

                throw new \InvalidArgumentException(
Severity: Minor
Found in src/lib360/db/language/SQL.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getByName has a boolean flag argument $connect, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function getByName($name, $connect = true)
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '69', column '23').
Open

            throw new \OutOfBoundsException("Offset $key does not exist.");
Severity: Minor
Found in src/lib360/db/data/Record.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '120', column '23').
Open

            throw new \InvalidArgumentException("Unable to find object type definition for $type");
Severity: Minor
Found in src/lib360/db/object/Factory.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method addString has a boolean flag argument $hintSpace, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addString($query, $hintSpace = true)
Severity: Minor
Found in src/lib360/db/query/Query.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addString has a boolean flag argument $hintSpace, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addString($query, $hintSpace = true);
Severity: Minor
Found in src/lib360/db/query/IQuery.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '171', column '23').
Open

            throw new \BadMethodCallException("Method $operation is not implemented.");
Severity: Minor
Found in src/lib360/api/router/Rest.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '67', column '23').
Open

            throw new \InvalidArgumentException("Connection by the name $name does not exist");
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '89', column '23').
Open

            throw new \InvalidArgumentException("Connection by the name $name does not exist.");
Severity: Minor
Found in src/lib360/db/connection/Pool.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Function getRequest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRequest()
    {
        $request = new api\Request();
        if (strpos($_SERVER['REQUEST_URI'], '?') === false) {
            $request->parts = explode('/', $_SERVER['REQUEST_URI']);
Severity: Minor
Found in src/lib360/api/request/handler/Rest.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function handle()
    {
        $request = $this->getRequest();
        if ($this->authenticate($request)) {
            try {
Severity: Minor
Found in src/lib360/api/request/Handler.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using static access to class '\spoof\lib360\db\object\Factory' in method '__construct'.
Open

        $this->driver = Factory::get(Factory::OBJECT_TYPE_DRIVER, $driverName);
Severity: Minor
Found in src/lib360/db/connection/Connection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method get uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if (!isset(self::$types[$type])) {
                throw new TypeNotFoundException("Undefined object type $type");
            }
            $class = self::$types[$type]['base'] . $name;
Severity: Minor
Found in src/lib360/db/object/Factory.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Severity
Category
Status
Source
Language