vaimo/composer-patches

View on GitHub
src/Compatibility/DependenciesFactory.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '18', column '21').
Open

        return  new \Composer\Repository\InstalledRepository(array($repository));

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '15', column '24').
Open

            return new \Composer\Repository\CompositeRepository(array($repository));

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\Composer\Composer' in method 'createCompositeRepository'.
Open

        if (version_compare(\Composer\Composer::getVersion(), '2.0', '<')) {

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Composer\Composer' in method 'createPackageDownloader'.
Open

        if (version_compare(\Composer\Composer::getVersion(), '2.0', '<')) {

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Composer\Composer' in method 'createFileDownloader'.
Open

        if (version_compare(\Composer\Composer::getVersion(), '2.0', '<')) {

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method __construct from undeclared class \Composer\Repository\CompositeRepository
Open

            return new \Composer\Repository\CompositeRepository(array($repository));
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

Call to method __construct from undeclared class \Composer\Repository\InstalledRepository
Open

        return  new \Composer\Repository\InstalledRepository(array($repository));
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

Call to method getDownloaderForPackage from undeclared class \Composer\Downloader\DownloadManager
Open

        return $baseDownloader->getDownloaderForPackage($package);
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

Call to method __construct from undeclared class \Composer\Downloader\FileDownloader
Open

        return new FileDownloader($appIO, $composerConfig, $httpDownloader, null, $cache);
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

Call to method getVersion from undeclared class \Composer\Composer
Open

        if (version_compare(\Composer\Composer::getVersion(), '2.0', '<')) {
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

Call to method getDownloaderForInstalledPackage from undeclared class \Composer\Downloader\DownloadManager
Open

            return $baseDownloader->getDownloaderForInstalledPackage($package);
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

Call to method getLoop from undeclared class \Composer\Composer
Open

        $httpDownloader = $composer->getLoop()->getHttpDownloader();
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

Call to method getVersion from undeclared class \Composer\Composer
Open

        if (version_compare(\Composer\Composer::getVersion(), '2.0', '<')) {
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

Call to method __construct from undeclared class \Composer\Downloader\FileDownloader
Open

            return new FileDownloader($appIO, $composerConfig, null, $cache);
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

Call to method getVersion from undeclared class \Composer\Composer
Open

        if (version_compare(\Composer\Composer::getVersion(), '2.0', '<')) {
Severity: Critical
Found in src/Compatibility/DependenciesFactory.php by phan

There are no issues that match your filters.

Category
Status