Sign upLogin

vaimo/composer-patches

View on GitHub
Star
src/Composer/Plugin/PackageResolver.php

Summary

Maintainability
A
35 mins
Test Coverage

Function resolveForNamespace has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function resolveForNamespace(array $packages, $namespace)
    {
        $packages = array_merge($this->additionalPackages, $packages);

        foreach ($packages as $package) {
Severity: Minor
Found in src/Composer/Plugin/PackageResolver.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '28', column '38').
Open

        $this->packageAnalyser = new \Vaimo\ComposerPatches\Package\ConfigAnalyser();
Severity: Minor
Found in src/Composer/Plugin/PackageResolver.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '53', column '19').
Open

        throw new \Vaimo\ComposerPatches\Exceptions\PackageResolverException(
Severity: Minor
Found in src/Composer/Plugin/PackageResolver.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Return type of resolveForNamespace() is undeclared type \Composer\Package\PackageInterface
Open

    public function resolveForNamespace(array $packages, $namespace)
Severity: Minor
Found in src/Composer/Plugin/PackageResolver.php by phan

Parameter $additionalPackages has undeclared type \Composer\Package\PackageInterface[]
Open

    public function __construct(
Severity: Minor
Found in src/Composer/Plugin/PackageResolver.php by phan

Property \Vaimo\ComposerPatches\Composer\Plugin\PackageResolver->additionalPackages has undeclared type \Composer\Package\PackageInterface[]
Open

    private $additionalPackages;
Severity: Minor
Found in src/Composer/Plugin/PackageResolver.php by phan

Parameter $packages has undeclared type \Composer\Package\PackageInterface[]
Open

    public function resolveForNamespace(array $packages, $namespace)
Severity: Minor
Found in src/Composer/Plugin/PackageResolver.php by phan

There are no issues that match your filters.

Category
Status