Sign upLogin

vaimo/composer-patches

View on GitHub
Star
src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function resolveComparisonResults has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function resolveComparisonResults(array $patchConstraints, array $packages, array $rootRequires)
    {
        $comparisonResults = array();

        foreach ($patchConstraints as $constraintTarget => $version) {
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolveComparisonResults has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function resolveComparisonResults(array $patchConstraints, array $packages, array $rootRequires)
    {
        $comparisonResults = array();

        foreach ($patchConstraints as $constraintTarget => $version) {
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php - About 1 hr to fix

    Function process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function process(array $patches, array $packagesByName)
    {
        $rootPackages = array_filter(
            $packagesByName,
            function ($package) {
    Severity: Minor
    Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function process(array $patches, array $packagesByName)
    {
        $rootPackages = array_filter(
            $packagesByName,
            function ($package) {
    Severity: Minor
    Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php - About 1 hr to fix

      Missing class import via use statement (line '39', column '36').
      Open

              $this->versionParser = new \Composer\Package\Version\VersionParser();
      Severity: Minor
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '40', column '38').
      Open

              $this->constraintUtils = new \Vaimo\ComposerPatches\Utils\ConstraintUtils();
      Severity: Minor
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '41', column '35').
      Open

              $this->packageUtils = new \Vaimo\ComposerPatches\Utils\PackageUtils();
      Severity: Minor
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Parameter $packagesByName has undeclared type \Composer\Package\PackageInterface[]
      Open

          public function process(array $patches, array $packagesByName)
      Severity: Minor
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phan

      Checking instanceof against undeclared class \Composer\Package\RootPackageInterface
      Open

                      return $package instanceof \Composer\Package\RootPackageInterface;
      Severity: Critical
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phan

      Call to method __construct from undeclared class \Composer\Package\Version\VersionParser
      Open

              $this->versionParser = new \Composer\Package\Version\VersionParser();
      Severity: Critical
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phan

      Call to method getDevRequires from undeclared class \Composer\Package\PackageInterface
      Open

                  $rootPackage->getDevRequires()
      Severity: Critical
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phan

      Property \Vaimo\ComposerPatches\Patch\DefinitionList\LoaderComponents\ConstraintsComponent->versionParser has undeclared type \Composer\Package\Version\VersionParser
      Open

          private $versionParser;
      Severity: Minor
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phan

      Call to method parseConstraints from undeclared class \Composer\Package\Version\VersionParser
      Open

                      $packageConstraint = $this->versionParser->parseConstraints($packageVersion);
      Severity: Critical
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phan

      Call to method parseConstraints from undeclared class \Composer\Package\Version\VersionParser
      Open

                      $patchConstraint = $this->versionParser->parseConstraints($version);
      Severity: Critical
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phan

      Call to method getRequires from undeclared class \Composer\Package\PackageInterface
      Open

                  $rootPackage->getRequires(),
      Severity: Critical
      Found in src/Patch/DefinitionList/LoaderComponents/ConstraintsComponent.php by phan

      There are no issues that match your filters.

      Category
      Status