Sign upLogin

vaimo/composer-patches

View on GitHub
Star
src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function process(array $patches, array $packagesByName)
    {
        /** @var \Composer\Package\CompletePackageInterface $rootPackage */
        $packages = $this->constraintPackages;
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function resolveComparisonResults has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function resolveComparisonResults(array $patchConstraints, array $packages)
    {
        $comparisonResults = array();

        foreach ($patchConstraints as $constraintTarget => &$version) {
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '28', column '36').
Open

        $this->versionParser = new \Composer\Package\Version\VersionParser();
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid unused parameters such as '$packagesByName'.
Open

    public function process(array $patches, array $packagesByName)
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Property \Vaimo\ComposerPatches\Patch\DefinitionList\LoaderComponents\PlatformComponent->versionParser has undeclared type \Composer\Package\Version\VersionParser
Open

    private $versionParser;
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php by phan

Call to method __construct from undeclared class \Composer\Package\Version\VersionParser
Open

        $this->versionParser = new \Composer\Package\Version\VersionParser();
Severity: Critical
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php by phan

Call to method parseConstraints from undeclared class \Composer\Package\Version\VersionParser
Open

                $packageConstraint = $this->versionParser->parseConstraints($packageVersion);
Severity: Critical
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php by phan

Property \Vaimo\ComposerPatches\Patch\DefinitionList\LoaderComponents\PlatformComponent->constraintPackages has undeclared type \Composer\Package\PackageInterface[]
Open

    private $constraintPackages;
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php by phan

Parameter $packagesByName has undeclared type \Composer\Package\PackageInterface[]
Open

    public function process(array $patches, array $packagesByName)
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php by phan

Call to method parseConstraints from undeclared class \Composer\Package\Version\VersionParser
Open

                $patchConstraint = $this->versionParser->parseConstraints($version);
Severity: Critical
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php by phan

Parameter $constraintPackages has undeclared type \Composer\Package\PackageInterface[]
Open

    public function __construct(
Severity: Minor
Found in src/Patch/DefinitionList/LoaderComponents/PlatformComponent.php by phan

There are no issues that match your filters.

Category
Status