Sign upLogin

vaimo/composer-patches

View on GitHub
Star
src/Repository/PatchesApplier/QueueGenerator.php

Summary

Maintainability
A
1 hr
Test Coverage

Method updateStatusMarkers has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function updateStatusMarkers($patches, $repositoryState)
    {
        $patchesByTarget = $this->patchListTransformer->createTargetsList(array_map('array_filter', $patches));
        $patchFootprints = $this->patchListTransformer->createSimplifiedList($patchesByTarget);
Severity: Minor
Found in src/Repository/PatchesApplier/QueueGenerator.php - About 1 hr to fix

    Function updateStatusMarkers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function updateStatusMarkers($patches, $repositoryState)
    {
        $patchesByTarget = $this->patchListTransformer->createTargetsList(array_map('array_filter', $patches));
        $patchFootprints = $this->patchListTransformer->createSimplifiedList($patchesByTarget);
    Severity: Minor
    Found in src/Repository/PatchesApplier/QueueGenerator.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '53', column '40').
    Open

            $this->patchListAnalyser = new \Vaimo\ComposerPatches\Patch\DefinitionList\Analyser();
    Severity: Minor
    Found in src/Repository/PatchesApplier/QueueGenerator.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '55', column '43').
    Open

            $this->patchListTransformer = new \Vaimo\ComposerPatches\Patch\DefinitionList\Transformer();
    Severity: Minor
    Found in src/Repository/PatchesApplier/QueueGenerator.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '56', column '37').
    Open

            $this->patchListUtils = new \Vaimo\ComposerPatches\Utils\PatchListUtils();
    Severity: Minor
    Found in src/Repository/PatchesApplier/QueueGenerator.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '54', column '39').
    Open

            $this->patchListUpdater = new \Vaimo\ComposerPatches\Patch\DefinitionList\Updater();
    Severity: Minor
    Found in src/Repository/PatchesApplier/QueueGenerator.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Define a constant instead of duplicating this literal "array_filter" 3 times.
    Open

            $patchesByTarget = $this->patchListTransformer->createTargetsList(array_map('array_filter', $patches));
    Severity: Critical
    Found in src/Repository/PatchesApplier/QueueGenerator.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    There are no issues that match your filters.

    Category
    Status