Sign upLogin

valasek/timesheet

View on GitHub
Star
server/models/reportedRecords.go

Summary

Maintainability
A
1 hr
Test Coverage

Method ReportedRecordManager.ReportedRecordUpdate has 5 return statements (exceeds 4 allowed).
Open

func (db *ReportedRecordManager) ReportedRecordUpdate(r UpdatedValue) ReportedRecord {
    updateValue := UpdatedValue{
        ID:    r.ID,
        Type:  r.Type,
        Value: r.Value,
Severity: Major
Found in server/models/reportedRecords.go - About 35 mins to fix

    Function getborderDays has 5 return statements (exceeds 4 allowed).
    Open

    func getborderDays(year, month string) (days []string, err error) {
    layout := "2006-1-02"
    monthStart, err := time.Parse(layout, year+"-"+month+"-01")
    if err != nil {
        return nil, err
    Severity: Major
    Found in server/models/reportedRecords.go - About 35 mins to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      func (db *ReportedRecordManager) ReportedRecordCount() int {
    reportedRecords := []ReportedRecord{}
    var count int
    if err := db.db.Find(&reportedRecords).Count(&count); err != nil {
        return count
      Severity: Major
      Found in server/models/reportedRecords.go and 4 other locations - About 40 mins to fix
      server/models/consultants.go on lines 165..173
      server/models/holidays.go on lines 84..92
      server/models/projects.go on lines 156..164
      server/models/rates.go on lines 77..85

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status