vibbix/BallroomCalculator

View on GitHub
app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java

Summary

Maintainability
D
2 days
Test Coverage

MainActivityInstrumentationTests has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

@RunWith(AndroidJUnit4.class)
@LargeTest
public class MainActivityInstrumentationTests {
    @Rule
    public ActivityTestRule mActivityRule = new ActivityTestRule<>(activity_main.class);

    Method setChecked has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static ViewAction setChecked(final boolean checked) {
            return new ViewAction() {
                @Override
                public Matcher<View> getConstraints() {
                    return new Matcher<View>() {

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Test
          public void verifyMetricCalculations() {
              onView(withId(R.id.switchMetric)).perform(setChecked(true));
              onView(withId(R.id.switchEasy)).perform(setChecked(false));
              onView(withId(R.id.seekEfficiency)).perform(setProgress(70));
      app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 177..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 163.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Test
          public void verifyImperialCalculations() {
              onView(withId(R.id.switchMetric)).perform(setChecked(false));
              onView(withId(R.id.switchEasy)).perform(setChecked(false));
              onView(withId(R.id.seekEfficiency)).perform(setProgress(74));
      app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 152..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 163.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Test
          public void verifyMetricCalculationsEasy() {
              onView(withId(R.id.switchMetric)).perform(setChecked(true));
              onView(withId(R.id.switchEasy)).perform(setChecked(true));
              onView(withId(R.id.decimalArea)).perform(ViewActions.replaceText("10.0"));
      app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 190..199

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Test
          public void verifyImperialCalculationsEasy() {
              onView(withId(R.id.switchMetric)).perform(setChecked(false));
              onView(withId(R.id.switchEasy)).perform(setChecked(true));
              onView(withId(R.id.decimalArea)).perform(ViewActions.replaceText("10.0"));
      app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 166..175

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 125.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Test
          public void changeToImperial() {
              onView(withId(R.id.switchMetric)).perform(setChecked(false));
              onView(withId(R.id.switchEasy)).perform(setChecked(false));
              onView(withId(R.id.txtunitSquared)).check(matches(withText(R.string.FeetSquared)));
      app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 114..122

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 111.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Test
          public void changeToMetric(){
              onView(withId(R.id.switchMetric)).perform(setChecked(true));
              onView(withId(R.id.switchEasy)).perform(setChecked(false));
              onView(withId(R.id.txtunitSquared)).check(matches(withText(R.string.MeterSquared)));
      app/src/androidTest/java/com/vibbix/ballroom/MainActivityInstrumentationTests.java on lines 124..131

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 111.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status