Sign upLogin

vindi/vindi-woocommerce

View on GitHub
Star

Showing 2,474 of 2,474 total issues

The method isMerchantStatusTrialOrSandbox has a boolean flag argument $is_config, which is a certain sign of a Single Responsibility Principle violation.
Open

  public function isMerchantStatusTrialOrSandbox($is_config = false)
Severity: Minor
Found in src/routes/RoutesApi.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid too many return statements within this method.
Open

        return $cycles > 0 ? $cycles : null;
Severity: Major
Found in src/utils/PaymentProcessor.php - About 30 mins to fix

    The method suspendSubscription has a boolean flag argument $cancel_bills, which is a certain sign of a Single Responsibility Principle violation.
    Open

      public function suspendSubscription($subscription_id, $cancel_bills = false)
    Severity: Minor
    Found in src/routes/RoutesApi.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method create has a boolean flag argument $recreated, which is a certain sign of a Single Responsibility Principle violation.
    Open

      function create($post_id, $post, $update, $recreated = false)
    Severity: Minor
    Found in src/controllers/PlansController.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method getMerchant has a boolean flag argument $is_config, which is a certain sign of a Single Responsibility Principle violation.
    Open

      public function getMerchant($is_config = false)
    Severity: Minor
    Found in src/routes/RoutesApi.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method abort has a boolean flag argument $throw_exception, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function abort($message, $throw_exception = false)
    Severity: Minor
    Found in src/utils/PaymentProcessor.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Function filter_pre_status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function filter_pre_status($wc_subscription, $new_status, $old_status)
    {
        switch ($new_status) {
            case 'on-hold':
                $this->suspend_status($wc_subscription);
    Severity: Minor
    Found in src/utils/SubscriptionStatusHandler.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function coupon_supports_product has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function coupon_supports_product($order_item, $coupon)
    {
        $product_id = $order_item->get_product()->get_id();
        $included_products = $coupon->get_product_ids();
        $excluded_products = $coupon->get_excluded_product_ids();
    Severity: Minor
    Found in src/utils/PaymentProcessor.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function calculate_cost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      public function calculate_cost($cart) {
    global $woocommerce;
        if (is_admin() && !is_ajax()) {
          return;
        }
    Severity: Minor
    Found in src/utils/InterestPriceHandler.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function bill_paid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function bill_paid($data)
    {
        try {
            if (empty($data->bill->subscription)) {
              $order = $this->find_order_by_id($data->bill->code);
    Severity: Minor
    Found in src/services/Webhooks.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused private fields such as '$types'.
    Open

      private $types;
    Severity: Minor
    Found in src/controllers/PlansController.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    The method create() has an NPath complexity of 1291438080. The configured NPath complexity threshold is 200.
    Open

      function create($post_id, $post, $update, $recreated = false)
  {

    // Check if the post is a draft
    if (strpos(get_post_status($post_id), 'draft') !== false) {
    Severity: Minor
    Found in src/controllers/PlansController.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    Avoid using static access to class 'VindiPaymentGateways\VindiConversions' in method 'create'.
    Open

            $trigger_day = VindiConversions::convertTriggerToDay(
          $product->get_meta('_subscription_trial_length'),
          $product->get_meta('_subscription_trial_period')
        );
    Severity: Minor
    Found in src/controllers/PlansController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method create uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

              } else {
            set_transient('vindi_product_message', 'error', 60);
          }
    Severity: Minor
    Found in src/controllers/ProductController.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method update uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

          } else {
        // Pessoa física
        $cpf_or_cnpj = $order->get_meta('_billing_cpf');
        $this->vindi_settings->logger->log(sprintf('Order cpf -> %s', $cpf_or_cnpj));
        $this->vindi_settings->logger->log(sprintf('Customer cpf -> %s', $customer->get_meta('billing_cpf')));
    Severity: Minor
    Found in src/controllers/CustomerController.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method update() has 160 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

      function update($post_id)
  {
    $product = wc_get_product($post_id);

    // Check if the post is of the signature type
    Severity: Minor
    Found in src/controllers/PlansController.php by phpmd

    Avoid using static access to class 'VindiPaymentGateways\VindiConversions' in method 'update'.
    Open

            $trigger_day = VindiConversions::convertTriggerToDay(
          $product->get_meta('_subscription_trial_length'),
          $product->get_meta('_subscription_trial_period')
        );
    Severity: Minor
    Found in src/controllers/PlansController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method create() has an NPath complexity of 768. The configured NPath complexity threshold is 200.
    Open

      function create($post_id, $post, $update, $recreated = false)
  {
        // Check if the post is a draft
        if (strpos(get_post_status($post_id), 'draft') !== false) {
          return;
    Severity: Minor
    Found in src/controllers/ProductController.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    Avoid unused parameters such as '$update'.
    Open

      function create($post_id, $post, $update, $recreated = false)
    Severity: Minor
    Found in src/controllers/ProductController.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid assigning values to variables in if clauses and the like (line '377', column '9').
    Open

      public function deleteBill($bill_id, $comments = '')
  {
    $query = '';

    if($comments)
    Severity: Minor
    Found in src/routes/RoutesApi.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Severity
    Category
    Status
    Source
    Language