Sign upLogin

visavi/rotor

View on GitHub
Star

Showing 512 of 512 total issues

Method add has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function add(Request $request, Validator $validator, Flood $flood): RedirectResponse
    {
        $msg = $request->input('msg');
        $user = getUser();
Severity: Minor
Found in app/Http/Controllers/GuestbookController.php - About 1 hr to fix

    Method ban has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function ban(Request $request, Validator $validator)
    {
        if (! $user = getUser()) {
            abort(403, __('main.not_authorized'));
        }
    Severity: Minor
    Found in app/Http/Controllers/User/BanController.php - About 1 hr to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      <?php

declare(strict_types=1);

use Illuminate\Database\Migrations\Migration;
      Severity: Major
      Found in database/migrations/2018_04_20_180029_create_notebooks_table.php and 4 other locations - About 1 hr to fix
      database/migrations/2018_04_20_180013_create_counters24_table.php on lines 1..35
      database/migrations/2018_04_20_180014_create_counters31_table.php on lines 1..35
      database/migrations/2018_04_20_180046_create_surprise_table.php on lines 1..35
      database/migrations/2018_11_04_134622_create_messages_table.php on lines 1..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      <?php

declare(strict_types=1);

use Illuminate\Database\Migrations\Migration;
      Severity: Major
      Found in database/migrations/2018_11_04_134622_create_messages_table.php and 4 other locations - About 1 hr to fix
      database/migrations/2018_04_20_180013_create_counters24_table.php on lines 1..35
      database/migrations/2018_04_20_180014_create_counters31_table.php on lines 1..35
      database/migrations/2018_04_20_180029_create_notebooks_table.php on lines 1..35
      database/migrations/2018_04_20_180046_create_surprise_table.php on lines 1..35

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      <?php

declare(strict_types=1);

use Illuminate\Database\Migrations\Migration;
      Severity: Major
      Found in database/migrations/2018_04_20_180014_create_counters31_table.php and 4 other locations - About 1 hr to fix
      database/migrations/2018_04_20_180013_create_counters24_table.php on lines 1..35
      database/migrations/2018_04_20_180029_create_notebooks_table.php on lines 1..35
      database/migrations/2018_04_20_180046_create_surprise_table.php on lines 1..35
      database/migrations/2018_11_04_134622_create_messages_table.php on lines 1..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      <?php

declare(strict_types=1);

use Illuminate\Database\Migrations\Migration;
      Severity: Major
      Found in database/migrations/2018_04_20_180013_create_counters24_table.php and 4 other locations - About 1 hr to fix
      database/migrations/2018_04_20_180014_create_counters31_table.php on lines 1..35
      database/migrations/2018_04_20_180029_create_notebooks_table.php on lines 1..35
      database/migrations/2018_04_20_180046_create_surprise_table.php on lines 1..35
      database/migrations/2018_11_04_134622_create_messages_table.php on lines 1..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      <?php

declare(strict_types=1);

use Illuminate\Database\Migrations\Migration;
      Severity: Major
      Found in database/migrations/2018_04_20_180046_create_surprise_table.php and 4 other locations - About 1 hr to fix
      database/migrations/2018_04_20_180013_create_counters24_table.php on lines 1..35
      database/migrations/2018_04_20_180014_create_counters31_table.php on lines 1..35
      database/migrations/2018_04_20_180029_create_notebooks_table.php on lines 1..35
      database/migrations/2018_11_04_134622_create_messages_table.php on lines 1..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method editItem has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function editItem(int $id, Request $request, Validator $validator)
    {
        /** @var Item $item */
        $item = Item::query()->find($id);
      Severity: Minor
      Found in app/Http/Controllers/Admin/BoardController.php - About 1 hr to fix

        Method comments has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function comments(int $id, Request $request, Validator $validator, Flood $flood)
    {
        /** @var News $news */
        $news = News::query()->find($id);
        Severity: Minor
        Found in app/Http/Controllers/NewsController.php - About 1 hr to fix

          Method forums has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function forums(int $id): Response
    {
        /** @var Forum $forum */
        $forum = Forum::query()->find($id);
          Severity: Minor
          Found in app/Http/Controllers/ApiController.php - About 1 hr to fix

            Method userlist has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function userlist(Request $request)
    {
        $type = check($request->input('type', 'users'));
        $sort = check($request->input('sort', 'point'));
        $user = $request->input('user', getUser('login'));
            Severity: Minor
            Found in app/Http/Controllers/User/ListController.php - About 1 hr to fix

              Method edit has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function edit(int $id, Request $request, Validator $validator)
    {
        /** @var News $news */
        $news = News::query()->find($id);
        $page = int($request->input('page', 1));
              Severity: Minor
              Found in app/Http/Controllers/Admin/NewsController.php - About 1 hr to fix

                Method comments has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function comments(int $id, Request $request, Validator $validator, Flood $flood): View|RedirectResponse
    {
        /** @var Down $down */
        $down = Down::query()->find($id);
                Severity: Minor
                Found in app/Http/Controllers/Load/DownController.php - About 1 hr to fix

                  Method create has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function create(Request $request, Validator $validator)
    {
        if ($request->isMethod('post')) {
            $title = $request->input('title');
            $text = $request->input('text');
                  Severity: Minor
                  Found in app/Http/Controllers/Admin/NewsController.php - About 1 hr to fix

                    Method vote has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function vote(int $id, Request $request, Validator $validator): RedirectResponse
    {
        if (! $user = getUser()) {
            abort(403, __('main.not_authorized'));
        }
                    Severity: Minor
                    Found in app/Http/Controllers/Forum/TopicController.php - About 1 hr to fix

                      Function icons has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function icons(string $ext): HtmlString
{
    switch ($ext) {
        case 'php':
            $ico = 'fa-regular fa-file-code';
                      Severity: Minor
                      Found in app/helpers.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method zipView has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function zipView(int $id, int $fid): View
    {
        /** @var File $file */
        $file = File::query()->where('relate_type', Down::$morphName)->find($id);
        $down = $file?->relate;
                      Severity: Minor
                      Found in app/Http/Controllers/Load/DownController.php - About 1 hr to fix

                        Method comments has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function comments(int $id, Request $request, Validator $validator, Flood $flood)
    {
        /** @var Photo $photo */
        $photo = Photo::query()->find($id);
                        Severity: Minor
                        Found in app/Http/Controllers/PhotoController.php - About 1 hr to fix

                          Method topic has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function topic(int $id): View
    {
        $topic = Topic::query()->where('id', $id)->with('forum.parent')->first();

        if (! $topic) {
                          Severity: Minor
                          Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

                            Method surprise has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function surprise(): RedirectResponse
    {
        $money = mt_rand(10000, 50000);
        $point = mt_rand(150, 250);
        $rating = mt_rand(3, 10);
                            Severity: Minor
                            Found in app/Http/Controllers/PageController.php - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language