visavi/rotor

View on GitHub

Showing 512 of 512 total issues

Method editComment has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function editComment(int $id, int $cid, Request $request, Validator $validator)
    {
        $page = int($request->input('page', 1));

        if (! $user = getUser()) {
Severity: Minor
Found in app/Http/Controllers/PhotoController.php - About 1 hr to fix

    Method editComment has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function editComment(int $id, int $cid, Request $request, Validator $validator)
        {
            $page = int($request->input('page', 1));
    
            /** @var Offer $offer */
    Severity: Minor
    Found in app/Http/Controllers/OfferController.php - About 1 hr to fix

      Method editComment has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function editComment(int $id, int $cid, Request $request, Validator $validator): View|RedirectResponse
          {
              $page = int($request->input('page', 1));
      
              /** @var Article $article */
      Severity: Minor
      Found in app/Http/Controllers/ArticleController.php - About 1 hr to fix

        Method login has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function login(Request $request, Validator $validator, Flood $flood)
            {
                if (getUser()) {
                    setFlash('danger', __('main.already_authorized'));
        
        
        Severity: Minor
        Found in app/Http/Controllers/User/UserController.php - About 1 hr to fix

          Method create has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function create(Request $request, Validator $validator)
              {
                  if ($request->isMethod('post')) {
                      $question = $request->input('question');
                      $description = $request->input('description');
          Severity: Minor
          Found in app/Http/Controllers/VoteController.php - About 1 hr to fix

            Function actionTopic has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function actionTopic(int $id, Request $request): RedirectResponse
                {
                    $page = int($request->input('page', 1));
            
                    /** @var Topic $topic */
            Severity: Minor
            Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function create(Request $request, Validator $validator)
                {
                    if ($request->isMethod('post')) {
                        $question = $request->input('question');
                        $description = $request->input('description');
            Severity: Minor
            Found in app/Http/Controllers/VoteController.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function create(Request $request, Validator $validator)
                {
                    if (! is_writable(resource_path('views/' . $this->path))) {
                        abort(200, __('admin.files.directory_not_writable', ['dir' => $this->path]));
                    }
            Severity: Minor
            Found in app/Http/Controllers/Admin/FileController.php - About 1 hr to fix

              Method recovery has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function recovery(Request $request, Validator $validator)
                  {
                      if (getUser()) {
                          setFlash('danger', __('main.already_authorized'));
              
              
              Severity: Minor
              Found in app/Http/Controllers/MailController.php - About 1 hr to fix

                Method index has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function index(Request $request, Validator $validator)
                    {
                        $login = $request->input('user');
                
                        if ($request->isMethod('post')) {
                Severity: Minor
                Found in app/Http/Controllers/IgnoreController.php - About 1 hr to fix

                  Method editComment has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function editComment(int $id, int $cid, Request $request, Validator $validator)
                      {
                          $page = int($request->input('page', 1));
                  
                          /** @var News $news */
                  Severity: Minor
                  Found in app/Http/Controllers/NewsController.php - About 1 hr to fix

                    Method change has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function change(Request $request, Validator $validator)
                        {
                            $user = User::query()->where('login', $request->input('user'))->with('lastBan')->first();
                    
                            if (! $user) {
                    Severity: Minor
                    Found in app/Http/Controllers/Admin/BanController.php - About 1 hr to fix

                      Method perform has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function perform(Request $request, Validator $validator): Response
                          {
                              if (! $request->ajax()) {
                                  return redirect('/');
                              }
                      Severity: Minor
                      Found in app/Http/Controllers/Forum/BookmarkController.php - About 1 hr to fix

                        Method file has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function file(?UploadedFile $input, array $rules, $label, bool $required = true): Validator
                            {
                                if (! $required && blank($input)) {
                                    return $this;
                                }
                        Severity: Minor
                        Found in app/Classes/Validator.php - About 1 hr to fix

                          Method user has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function user(Request $request): Response
                              {
                                  /** @var User $user */
                                  $user = $request->attributes->get('user');
                          
                          
                          Severity: Minor
                          Found in app/Http/Controllers/ApiController.php - About 1 hr to fix

                            Method topics has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function topics(int $id): Response
                                {
                                    /** @var Topic $topic */
                                    $topic = Topic::query()->find($id);
                            
                            
                            Severity: Minor
                            Found in app/Http/Controllers/ApiController.php - About 1 hr to fix

                              Method send has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function send(Request $request, Validator $validator): RedirectResponse
                                  {
                                      $money = int($request->input('money'));
                                      $msg = $request->input('msg');
                              
                              
                              Severity: Minor
                              Found in app/Http/Controllers/TransferController.php - About 1 hr to fix

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                            $validator->equal($request->input('_token'), csrf_token(), __('validator.token'))
                                                ->length($title, 3, 50, ['title' => __('validator.text')])
                                                ->length($text, 50, 5000, ['text' => __('validator.text')])
                                                ->notEmpty($category, ['category' => __('loads.load_not_exist')])
                                Severity: Major
                                Found in app/Http/Controllers/Load/DownController.php and 1 other location - About 1 hr to fix
                                app/Http/Controllers/Admin/LoadController.php on lines 230..233

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 108.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                            $validator->equal($request->input('_token'), csrf_token(), __('validator.token'))
                                                ->length($title, 3, 50, ['title' => __('validator.text')])
                                                ->length($text, 50, 5000, ['text' => __('validator.text')])
                                                ->notEmpty($category, ['category' => __('loads.load_not_exist')]);
                                Severity: Major
                                Found in app/Http/Controllers/Admin/LoadController.php and 1 other location - About 1 hr to fix
                                app/Http/Controllers/Load/DownController.php on lines 202..205

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 108.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                        $validator->equal($request->input('_token'), csrf_token(), ['msg' => __('validator.token')])
                                            ->length($msg, 5, setting('comment_length'), ['msg' => __('validator.text')])
                                            ->false($flood->isFlood(), ['msg' => __('validator.flood', ['sec' => $flood->getPeriod()])])
                                Severity: Major
                                Found in app/Http/Controllers/MessageController.php and 1 other location - About 1 hr to fix
                                app/Http/Controllers/GuestbookController.php on lines 40..42

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 108.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language