Sign upLogin

vorteil/direktiv

View on GitHub
Star
cmd/sidecar/local-server.go

Summary

Maintainability
D
2 days
Test Coverage

Method LocalServer.setVar has 103 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (srv *LocalServer) setVar(ctx context.Context, ir *functionRequest, totalSize int64, r io.Reader, scope, key, vMimeType string) error {
    var err error
    var client varSetClient
    var send func(*varSetClientMsg) error
Severity: Major
Found in cmd/sidecar/local-server.go - About 3 hrs to fix

    File local-server.go has 507 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package sidecar

import (
    "bytes"
    "context"
    Severity: Minor
    Found in cmd/sidecar/local-server.go - About 2 hrs to fix

      Method LocalServer.setVar has 12 return statements (exceeds 4 allowed).
      Open

      func (srv *LocalServer) setVar(ctx context.Context, ir *functionRequest, totalSize int64, r io.Reader, scope, key, vMimeType string) error {
    var err error
    var client varSetClient
    var send func(*varSetClientMsg) error
      Severity: Major
      Found in cmd/sidecar/local-server.go - About 1 hr to fix

        Method LocalServer.logHandler has 51 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (srv *LocalServer) logHandler(w http.ResponseWriter, r *http.Request) {
    actionId := r.URL.Query().Get("aid")

    srv.requestsLock.Lock()
    req, ok := srv.requests[actionId]
        Severity: Minor
        Found in cmd/sidecar/local-server.go - About 1 hr to fix

          Method LocalServer.setVar has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
          Open

          func (srv *LocalServer) setVar(ctx context.Context, ir *functionRequest, totalSize int64, r io.Reader, scope, key, vMimeType string) error {
    var err error
    var client varSetClient
    var send func(*varSetClientMsg) error
          Severity: Minor
          Found in cmd/sidecar/local-server.go - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method LocalServer.getVar has 6 return statements (exceeds 4 allowed).
          Open

          func (srv *LocalServer) getVar(ctx context.Context, ir *functionRequest, w io.Writer, setTotalSize func(x int64), scope, key string) error {
    client, recv, err := srv.requestVar(ctx, ir, scope, key)
    if err != nil {
        return err
    }
          Severity: Major
          Found in cmd/sidecar/local-server.go - About 40 mins to fix

            Method LocalServer.setVar has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (srv *LocalServer) setVar(ctx context.Context, ir *functionRequest, totalSize int64, r io.Reader, scope, key, vMimeType string) error {
            Severity: Minor
            Found in cmd/sidecar/local-server.go - About 35 mins to fix

              Method LocalServer.getVar has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func (srv *LocalServer) getVar(ctx context.Context, ir *functionRequest, w io.Writer, setTotalSize func(x int64), scope, key string) error {
              Severity: Minor
              Found in cmd/sidecar/local-server.go - About 35 mins to fix

                Method LocalServer.varHandler has 5 return statements (exceeds 4 allowed).
                Open

                func (srv *LocalServer) varHandler(w http.ResponseWriter, r *http.Request) {
    actionId := r.URL.Query().Get("aid")

    srv.requestsLock.Lock()
    req, ok := srv.requests[actionId]
                Severity: Major
                Found in cmd/sidecar/local-server.go - About 35 mins to fix

                  Method LocalServer.requestVar has 5 return statements (exceeds 4 allowed).
                  Open

                  func (srv *LocalServer) requestVar(ctx context.Context, ir *functionRequest, scope, key string) (client varClient, recv func() (varClientMsg, error), err error) {
    switch scope {
    case util.VarScopeFileSystem:
        var nvClient grpc.Internal_NamespaceVariableParcelsClient
        nvClient, err = srv.flow.FileVariableParcels(ctx, &grpc.VariableInternalRequest{
                  Severity: Major
                  Found in cmd/sidecar/local-server.go - About 35 mins to fix

                    Method LocalServer.logHandler has 5 return statements (exceeds 4 allowed).
                    Open

                    func (srv *LocalServer) logHandler(w http.ResponseWriter, r *http.Request) {
    actionId := r.URL.Query().Get("aid")

    srv.requestsLock.Lock()
    req, ok := srv.requests[actionId]
                    Severity: Major
                    Found in cmd/sidecar/local-server.go - About 35 mins to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          case util.VarScopeInstance:
        var ivClient grpc.Internal_SetInstanceVariableParcelsClient
        ivClient, err = srv.flow.SetInstanceVariableParcels(ctx)
        if err != nil {
            return err
                      Severity: Major
                      Found in cmd/sidecar/local-server.go and 2 other locations - About 1 hr to fix
                      cmd/sidecar/local-server.go on lines 478..495
                      cmd/sidecar/local-server.go on lines 497..514

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 168.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          case util.VarScopeWorkflow:
        var wvClient grpc.Internal_SetWorkflowVariableParcelsClient
        wvClient, err = srv.flow.SetWorkflowVariableParcels(ctx)
        if err != nil {
            return err
                      Severity: Major
                      Found in cmd/sidecar/local-server.go and 2 other locations - About 1 hr to fix
                      cmd/sidecar/local-server.go on lines 478..495
                      cmd/sidecar/local-server.go on lines 519..536

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 168.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          case util.VarScopeNamespace:
        var nvClient grpc.Internal_SetNamespaceVariableParcelsClient
        nvClient, err = srv.flow.SetNamespaceVariableParcels(ctx)
        if err != nil {
            return err
                      Severity: Major
                      Found in cmd/sidecar/local-server.go and 2 other locations - About 1 hr to fix
                      cmd/sidecar/local-server.go on lines 497..514
                      cmd/sidecar/local-server.go on lines 519..536

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 168.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      func (srv *LocalServer) run() {
    slog.Info("Starting localhost HTTP server.", "addr", srv.server.Addr)

    err := srv.server.ListenAndServe()
    if err != nil && !errors.Is(err, http.ErrServerClosed) {
                      Severity: Minor
                      Found in cmd/sidecar/local-server.go and 1 other location - About 35 mins to fix
                      cmd/sidecar/network-server.go on lines 115..125

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 106.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status