Sign upLogin

vorteil/direktiv

View on GitHub
Star
cmd/sidecar/local-server.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method LocalServer.varHandler has 79 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (srv *LocalServer) varHandler(w http.ResponseWriter, r *http.Request) {
    actionId := r.URL.Query().Get("aid")

    srv.requestsLock.Lock()
    req, ok := srv.requests[actionId]
Severity: Major
Found in cmd/sidecar/local-server.go - About 2 hrs to fix

    Method LocalServer.logHandler has 71 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (srv *LocalServer) logHandler(w http.ResponseWriter, r *http.Request) {
    actionId := r.URL.Query().Get("aid")

    srv.requestsLock.Lock()
    req, ok := srv.requests[actionId]
    Severity: Minor
    Found in cmd/sidecar/local-server.go - About 1 hr to fix

      Method LocalServer.logHandler has 8 return statements (exceeds 4 allowed).
      Open

      func (srv *LocalServer) logHandler(w http.ResponseWriter, r *http.Request) {
    actionId := r.URL.Query().Get("aid")

    srv.requestsLock.Lock()
    req, ok := srv.requests[actionId]
      Severity: Major
      Found in cmd/sidecar/local-server.go - About 50 mins to fix

        Method LocalServer.varHandler has 7 return statements (exceeds 4 allowed).
        Open

        func (srv *LocalServer) varHandler(w http.ResponseWriter, r *http.Request) {
    actionId := r.URL.Query().Get("aid")

    srv.requestsLock.Lock()
    req, ok := srv.requests[actionId]
        Severity: Major
        Found in cmd/sidecar/local-server.go - About 45 mins to fix

          Method LocalServer.setVar has 7 return statements (exceeds 4 allowed).
          Open

          func (srv *LocalServer) setVar(ctx context.Context, ir *functionRequest, r io.Reader, scope, key, vMimeType string) (int, error) {
    // Retrieve variable metadata
    varMeta, statusCode, err := getVariableMetaFromFlow(ctx, srv.flowToken, srv.flowAddr, ir, scope, key)
    if err != nil {
        target := &RessourceNotFoundError{}
          Severity: Major
          Found in cmd/sidecar/local-server.go - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (srv *LocalServer) run() {
    slog.Info("Starting localhost HTTP server.", "addr", srv.server.Addr)

    err := srv.server.ListenAndServe()
    if err != nil && !errors.Is(err, http.ErrServerClosed) {
            Severity: Minor
            Found in cmd/sidecar/local-server.go and 1 other location - About 35 mins to fix
            cmd/sidecar/network-server.go on lines 106..116

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status