Showing 1,235 of 1,235 total issues
Method fsController.createFile
has 6 return statements (exceeds 4 allowed). Open
func (e *fsController) createFile(w http.ResponseWriter, r *http.Request) {
ns := extractContextNamespace(r)
db, err := e.db.BeginTx(r.Context())
if err != nil {
Method ActionState.Validate
has 6 return statements (exceeds 4 allowed). Open
func (o *ActionState) Validate() error {
if err := o.commonValidate(); err != nil {
return err
}
Method eventsController.registerCoudEvent
has 6 return statements (exceeds 4 allowed). Open
func (c *eventsController) registerCoudEvent(w http.ResponseWriter, r *http.Request) {
ns := extractContextNamespace(r)
cType := r.Header.Get("Content-type")
limit := int64(1024 * 1024 * 32)
Method sqlRuntimeVariablesStore.Patch
has 6 return statements (exceeds 4 allowed). Open
func (s *sqlRuntimeVariablesStore) Patch(ctx context.Context, id uuid.UUID, patch *datastore.RuntimeVariablePatch) (*datastore.RuntimeVariable, error) {
if patch.Name != nil {
if *patch.Name == "" {
return nil, datastore.ErrInvalidRuntimeVariableName
}
Method RootQuery.GetFile
has 6 return statements (exceeds 4 allowed). Open
func (q *RootQuery) GetFile(ctx context.Context, path string) (*filestore.File, error) {
path, err := filestore.SanitizePath(path)
if err != nil {
return nil, fmt.Errorf("%w: %w", filestore.ErrInvalidPathParameter, err)
}
Method RootQuery.ReadDirectory
has 6 return statements (exceeds 4 allowed). Open
func (q *RootQuery) ReadDirectory(ctx context.Context, path string) ([]*filestore.File, error) {
var list []*filestore.File
path, err := filestore.SanitizePath(path)
if err != nil {
return nil, fmt.Errorf("%w: %w", filestore.ErrInvalidPathParameter, err)
Method varController.update
has 6 return statements (exceeds 4 allowed). Open
func (e *varController) update(w http.ResponseWriter, r *http.Request) {
id, err := uuid.Parse(chi.URLParam(r, "variableID"))
if err != nil {
writeError(w, &Error{
Code: "request_data_invalid",
Method sqlRuntimeVariablesStore.Create
has 6 return statements (exceeds 4 allowed). Open
func (s *sqlRuntimeVariablesStore) Create(ctx context.Context, variable *datastore.RuntimeVariable) (*datastore.RuntimeVariable, error) {
if variable.Name == "" {
return nil, datastore.ErrInvalidRuntimeVariableName
}
if matched, _ := regexp.MatchString(datastore.RuntimeVariableNameRegexPattern, variable.Name); !matched {
Method EventsAndState.Validate
has 6 return statements (exceeds 4 allowed). Open
func (o *EventsAndState) Validate() error {
if err := o.commonValidate(); err != nil {
return err
}
Method varController.create
has 6 return statements (exceeds 4 allowed). Open
func (e *varController) create(w http.ResponseWriter, r *http.Request) {
ns := extractContextNamespace(r)
db, err := e.db.BeginTx(r.Context())
if err != nil {
Method sqlMirrorStore.UpdateConfig
has 6 return statements (exceeds 4 allowed). Open
func (s sqlMirrorStore) UpdateConfig(ctx context.Context, config *datastore.MirrorConfig) (*datastore.MirrorConfig, error) {
config, err := cryptDecryptConfig(config, s.configEncryptionKey, true)
if err != nil {
return nil, err
}
Method EventsXorState.Validate
has 6 return statements (exceeds 4 allowed). Open
func (o *EventsXorState) Validate() error {
if err := o.commonValidate(); err != nil {
return err
}
Method RootQuery.checkRootExists
has 6 return statements (exceeds 4 allowed). Open
func (q *RootQuery) checkRootExists(ctx context.Context) error {
zeroUUID := (uuid.UUID{}).String()
if zeroUUID == q.rootID.String() {
n := &filestore.Root{}
Method ParallelState.Validate
has 6 return statements (exceeds 4 allowed). Open
func (o *ParallelState) Validate() error {
if err := o.commonValidate(); err != nil {
return err
}
Method nsController.create
has 6 return statements (exceeds 4 allowed). Open
func (e *nsController) create(w http.ResponseWriter, r *http.Request) {
// Parse request.
req := struct {
Name string `json:"name"`
Method logController.stream
has 6 return statements (exceeds 4 allowed). Open
func (m logController) stream(w http.ResponseWriter, r *http.Request) {
// cursor is set to multiple seconds before the current time to mitigate data loss
// that may occur due to delays between submitting and processing the request, or when a sequence of client requests is necessary.
cursor := time.Now().UTC().Add(-time.Second * 3)
Function determineTrack
has 6 return statements (exceeds 4 allowed). Open
func determineTrack(params map[string]string) (string, error) {
if p, ok := params["instance"]; ok {
return "flow.instance." + "%" + p + "%", nil
} else if p, ok := params["route"]; ok {
return "flow.route." + params["namespace"] + "." + p, nil
Similar blocks of code found in 3 locations. Consider refactoring. Open
func (e *secretsController) mountRouter(r chi.Router) {
r.Get("/{secretName}", e.get)
r.Delete("/{secretName}", e.delete)
r.Patch("/{secretName}", e.update)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 110.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
func (e *varController) mountRouter(r chi.Router) {
r.Get("/{variableID}", e.get)
r.Delete("/{variableID}", e.delete)
r.Patch("/{variableID}", e.update)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 110.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
func (e *nsController) mountRouter(r chi.Router) {
r.Get("/{name}", e.get)
r.Delete("/{name}", e.delete)
r.Patch("/{name}", e.update)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 110.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76