Sign upLogin

vorteil/direktiv

View on GitHub
Star
pkg/api/filesystem.go

Summary

Maintainability
C
1 day
Test Coverage

Method fsController.updateFile has 100 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (e *fsController) updateFile(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
Severity: Major
Found in pkg/api/filesystem.go - About 3 hrs to fix

    Method fsController.createFile has 66 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (e *fsController) createFile(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
    Severity: Minor
    Found in pkg/api/filesystem.go - About 1 hr to fix

      Method fsController.updateFile has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
      Open

      func (e *fsController) updateFile(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
      Severity: Minor
      Found in pkg/api/filesystem.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method fsController.updateFile has 10 return statements (exceeds 4 allowed).
      Open

      func (e *fsController) updateFile(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
      Severity: Major
      Found in pkg/api/filesystem.go - About 1 hr to fix

        Method fsController.createFile has 6 return statements (exceeds 4 allowed).
        Open

        func (e *fsController) createFile(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
        Severity: Major
        Found in pkg/api/filesystem.go - About 40 mins to fix

          Method fsController.read has 5 return statements (exceeds 4 allowed).
          Open

          func (e *fsController) read(w http.ResponseWriter, r *http.Request) {
    // handle raw file read.
    if r.URL.Query().Get("raw") == "true" {
        e.readRaw(w, r)
        return
          Severity: Major
          Found in pkg/api/filesystem.go - About 35 mins to fix

            Method fsController.readRaw has 5 return statements (exceeds 4 allowed).
            Open

            func (e *fsController) readRaw(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
            Severity: Major
            Found in pkg/api/filesystem.go - About 35 mins to fix

              Method fsController.delete has 5 return statements (exceeds 4 allowed).
              Open

              func (e *fsController) delete(w http.ResponseWriter, r *http.Request) {
    ns := extractContextNamespace(r)

    db, err := e.db.BeginTx(r.Context())
    if err != nil {
              Severity: Major
              Found in pkg/api/filesystem.go - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if req.Data != "" && updatedFile.Typ.IsDirektivSpecFile() {
        err = e.bus.DebouncedPublish(&pubsub.FileSystemChangeEvent{
            Action:      "update",
            FileType:    string(updatedFile.Typ),
            Namespace:   ns.Name,
                Severity: Minor
                Found in pkg/api/filesystem.go and 1 other location - About 35 mins to fix
                pkg/api/filesystem.go on lines 256..269

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if newFile.Typ.IsDirektivSpecFile() {
        err = e.bus.DebouncedPublish(&pubsub.FileSystemChangeEvent{
            Action:      "create",
            FileType:    string(newFile.Typ),
            Namespace:   ns.Name,
                Severity: Minor
                Found in pkg/api/filesystem.go and 1 other location - About 35 mins to fix
                pkg/api/filesystem.go on lines 384..397

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if req.Path != "" && updatedFile.Typ.IsDirektivSpecFile() {
        err = e.bus.DebouncedPublish(&pubsub.FileSystemChangeEvent{
            Action:      "rename",
            FileType:    string(updatedFile.Typ),
            Namespace:   ns.Name,
                Severity: Minor
                Found in pkg/api/filesystem.go and 1 other location - About 35 mins to fix
                pkg/api/filesystem.go on lines 171..183

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if file.Typ.IsDirektivSpecFile() {
        err = e.bus.DebouncedPublish(&pubsub.FileSystemChangeEvent{
            Action:       "delete",
            FileType:     string(file.Typ),
            Namespace:    ns.Name,
                Severity: Minor
                Found in pkg/api/filesystem.go and 1 other location - About 35 mins to fix
                pkg/api/filesystem.go on lines 369..381

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status